Giter Club home page Giter Club logo

pe's People

Contributors

skcheongbrian avatar

Watchers

 avatar

pe's Issues

Not enough visuals in the UG

A lot of the commands do not have visual aids and can be confusing to the user as they would not know what to expect when inputing a command.

Incorrect error messages when viewing an index of a large number

Steps to reproduce:

  • type view 9999999999999999999999999999999 in command box

Expected behaviour: There should be an error message "The person index provided is invalid"

Actual behaviour: There error message shown is "Invalid command format!
view: View the details of the person identified by the index number used in the displayed person list."

This is an incorrect behaviour as an index was given just that it was not valid. Severity is low as this is unlikely to happen in reality, however cannot be very low as it is not a cosmetic bug.

image.png

Profile name does not update if there is no profile at the start

Steps to reproduce:

  • Ensure there is no username set for the FriendBook yet
  • type in a profile name eg profile n/myname

Expected behaviour: "myname" should appear at the top next to "Welcome" similar to how it updates if a username had been set previously.

Actual behaviour: No change at the top of the bar despite the username being set. Have to restart to view a change in the username.

This can be considered a bug as the username at the top updates usually if there is already a username set. But does not update when no username is set. Severity is low as this does not really affect the performance of the app and does not really break the functionality of the app.

image.png

UG for add command does not have the sample output

In the UG there is example inputs about how to use the add command. However there is no explanation of the examples and no sample output. This can be bad as the user would not know what to expect when inputting the commands.

image.png

Long names get cut off and there is no way to view it

Step to reproduce:

  • Create a person with a very long name such that it cannot be viewed in the entire display.

Expected behaviour: Be able to scroll the display sideways to be able to view the entire name

Actual behaviour: No way to view the entire name of the person.

This is very low severity as it is extremely unlikely to happen and may be seen as a cosmetic issue. However it can be considered a bug if 2 people have the same long name except for the last few characters that cannot be visible thus the user cannot differentiate between the 2 people.

image.png

Command not destroyed in sequence diagram

In the sequence diagram illustrating the interactions within the Logic
component for the execute("delete 1") API call, the DeleteCommand should be destroyed at the end.

image.png

Mismatch in DG user stories

image.png

There is no link between having custom avatars to friends and being able to track their age through custom avatars. As the link is so far off it is a higher severity than very low.

Inconsistent term of friend, person or contact

In the User Guide, most commands use friend. However, some commands like delete uses person and view uses contact.

This is low severity as it is not a cosmetic issue but can reasonably understood to be referring to the same thing.

image.png

Incorrect UML diagram in Developer Guide

In the developer guide, it is said that the ParserUtil depends on Prefix. However when inspecting the code ParserUtil.java there is no import of Prefix. Thus it ParserUtil does not depend on on Prefix.

image.png

image.png

Allowed duplicate telegram handles

Steps to reproduce:

  • Create a person with the add command with a telegram handle
  • Create another person with the same telegram handle as the first person.

Expected Behaviour: A warning to show that there is 2 telegram handles or an error message to disallow duplicate telegram handles as telegram handles should be unique to each user.

Actual Behaviour: Able to create 2 persons with the same telegram handle.

image.png

image.png

Inconsistent term in DG user stories

image.png

States that to add a new person to keep in contact with the friend instead of person. As this seems to be a minor typo the severity is very low.

Wrong age displayed for notifications

Steps to reproduce:

  • Have a person's birthday be coming within 10 days

Expected behaviour: The pop-up should show the age the person is going to be when his birthday arrives (ie his current age + 1)

Actual behaviour: The pop up states the person is going to be his current age instead of the age he is going to be when his birthday arrives.

This can be considered a medium bug as keeping track of the persons birthday is one of the core features of the application. If a user receives the notification stating that a person is reaching a certain age and the age given is wrong it can be quite detrimental to the user.

image.png

No mention of whether friend's names added is case sensitive

There is no mention in the user guide whether names are case sensitive. As a user, I may assume that the name is case insensitive and would like to be told if the names are indeed case sensitive as to me I may treat "John Doe" and "john doe" as the same thing.

image.png

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.