sinesc / radiant-rs Goto Github PK

Should probably be Font::clone_with_size() to be in line with Layer::with_program() vs. Layer::clone_with_program()

Seems broken.

Currently required at draw time since the frame offset is not fixed and depends on the number of frames in the sprite.
To move this to Renderer::draw_layer(), Sprite::draw() would have to save the frame- and component count to the AVec. The absolute offset could be computed in the shader.

Step-by-step approach.

• First refactor components like Display, Texture, Sprite, ... to expose only abstracted API to the rest of the library (keep directly using glium internally within each component).
• todo: Needs more details.

Lookup some common blendmodes and see if they can be approximated with opengl blendfuncs.
Also look into KHR_blend_equation_advanced.

Currently fonts are created with a color and size.

• size: might make sense, maybe. (Technical reason was: Rusttype's FontCache needs a unique id per font. Might not actually need it per size though. Should be able to abstract it in either case.)
• color: not in line with sprites, color should be set during draw.

There are various methods to write text. These could be streamlined with a builder like draw_rect() was with RectBuilder.

Some backend methods accept backend types instead of radiant types. This should be changed, e.g. backend::Texture2d::new should accept a core::Display instead of a backend::Display.

Currently everything goes through shaders. Add an API to blit from one rendertarget to another.

Needs to be mostly drop-in and be easy to use.

Scene needs a simple means to perform an operation once.

As an alternative, support the builder pattern for Display, Font, Texture and possibly Sprite (which currently doesn't use the Info struct either)

Layer blendmodes should be configurable per layer component.

• Font::from_info can fail with a panic if no matching system font could be found. Since this is out of the control of the programmer it must be catchable.
• Display::new currently falls back to windowed silently if full-screen cannot be acquired.
• Display::new currently panics if the window cannot be created.
• sprite::parse_parameters panics if the filename is invalid. This might be ok, but needs helpful error message.

It is confirmed that radiant-rs suffers from an use-after-free vulnerablity within the target_frame public function, a possible panic thrown by draw_func would cause an uninitialized memory to be freed, which is equivalent to use-after-free (which is constantly exploitable).

pub fn target_frame<F>(renderer: &core::Renderer, frame: &mut glium::Frame, draw_func: F) where F: FnMut() {
    let wrapper = {
        let owned_frame = mem::replace(frame, unsafe { mem::uninitialized() });
        let backend_frame = super::Frame(owned_frame);
        Rc::new(RefCell::new(Some(backend_frame)))
    };
    renderer.render_to(&core::RenderTarget::frame(&wrapper), draw_func);
    let backend_frame = mem::replace(&mut *wrapper.borrow_mut(), None).unwrap();
    let owned_frame = backend_frame.into_inner();
    let uninitialized = mem::replace(frame, owned_frame);
    mem::forget(uninitialized);
}

Currently the shader can only access the selected sprite component and frame. It could be useful to be able to access any component and/or frame.