Giter Club home page Giter Club logo

Comments (5)

jopemachine avatar jopemachine commented on May 16, 2024

May I ask if I could take on this?

Here is my draft though I'm not sure all the interface names are enough intuitive.

I'd appreciate it if you could check and tell me if there's anything lacking.

Note:

  • The descriptions of attributes of ScriptFilterItem are be copied from JSON script filter format, and the other comments were copied from alfy READMD.

  • Since there is no type declarations in the cache-conf, I also typed it in here though I'm not sure this type should be here.

  • I've excluded action attritube from ScriptFilterItem because it is not implemented in Alfred yet. (According to this page, it is going to be introduced in Alfred 4.5)

I appreciate for always providing and maintaining lots of awesome libraries.

from alfy.

sindresorhus avatar sindresorhus commented on May 16, 2024

May I ask if I could take on this?

Sure, do a pull request. It's easier to give feedback directly then.

from alfy.

sindresorhus avatar sindresorhus commented on May 16, 2024

Since there is no type declarations in the cache-conf, I also typed it in here though I'm not sure this type should be here.

Maybe do a pull request to add types to that package? Link to it here and I'll ping the maintainer to review it.

from alfy.

sindresorhus avatar sindresorhus commented on May 16, 2024

I've excluded action attritube from ScriptFilterItem because it is not implemented in Alfred yet. (According to this page, it is going to be introduced in Alfred 4.5)

Add it commented out with a todo comment to enable it when Alfred 4.5 is out.

from alfy.

jopemachine avatar jopemachine commented on May 16, 2024

Thanks, I made a PR in here

from alfy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.