Search for multiple object properties in `alfy.matches` and `alfy.inputMatches` about alfy HOT 6 CLOSED

PR welcome for adding the tip to the readme.

from alfy.

I should have read the README.md more carefully. I made my example to work using includes as such:

import alfy from 'alfy';

const data = await alfy.fetch('https://jsonplaceholder.typicode.com/posts');

const items = alfy
  .inputMatches(
    data,
    (item, input) =>
      item.title.toLowerCase().includes(input) ||
      item.body.toLowerCase().includes(input)
  )
  .map((element) => ({
    title: element.title,
    subtitle: element.body,
    arg: element.id,
  }));

alfy.output(items);

from alfy.

In my specific example, I noticed that some properties may contain null on which toLowerCase() would fail. It makes sense to add optional chaining for such properties

import alfy from 'alfy';

const data = await alfy.fetch('https://jsonplaceholder.typicode.com/posts');

const items = alfy
  .inputMatches(
    data,
    (item, input) =>
      item.title?.toLowerCase().includes(input) ||
      item.body?.toLowerCase().includes(input)
  )
  .map((element) => ({
    title: element.title,
    subtitle: element.body,
    arg: element.id,
  }));

alfy.output(items);

from alfy.

Is this little example something worth adding to the README.md? Happy to propose a PR.

from alfy.

The problem with supporting multiple properties like this:

const items = alfy.inputMatches(data, ['title', 'body']).map((element) => ({
	title: element.title,
	subtitle: element.body,
	arg: element.id,
}));

is that it's not immediately clear whether either or both properties have to match.

from alfy.

The problem with supporting multiple properties like this:

const items = alfy.inputMatches(data, ['title', 'body']).map((element) => ({
	title: element.title,
	subtitle: element.body,
	arg: element.id,
}));

is that it's not immediately clear whether either or both properties have to match.

Good point. I was about to propose extending your dot.prop’s getProperty function, but that feels too over-engineered in the end.

from alfy.