sinankeskin / ember-inputmask Goto Github PK

It seems that inputmask is loaded using an app.import statement so it will be added to the vendor folder. Since it is quite a big dependency, it would be nice if there was an option to lazy-load that dependency when needed. Apps that don't heavily use input masks can then choose to not pay that cost when loading the app itself.

Maybe it would even be a nice default?

It would be nice if the input mask functionality was available as a custom modifier as well. That way it could be applied to any input element you want. It would also replace the need for ember-render-modifiers addon since the component could probably use that modifier internally.

Having difficulty with an old ember addon shimming inputmask I was using and just going to write my own, luckily stumbled across this which seems to be pretty close to what I would have done.

Would you be open to a PR that converts this to a V2 addon?

Also would like to do get some tests in to help with the ember observer score :)

It seems that a controller used in the dummy app was accidentally created in the addon folder which means it will be pulled into consuming apps as well.

Hi Sinan, thanks for the project,
We migrated from ember-inputmask to ember-inputmask5 it's working good but we had some trouble in order to use it.
We were considering adding a PR to add some docs + tests.
Is that ok? Do you have any specific doc/test in mind?