Signing a PSBT with some inputs not having utxo throws ValueError about python-bitcointx HOT 3 CLOSED

Yes, it looks like we should just return None if utxo is not set, now it always raises an exception

a few lines above there's also a check if the index is set on UTXO:

index on the input may be unset if someone created PSBT_Input directly and did not supply or did not set the index.

It seems to me that conceptually, in both of this cases we can just return "None" and not throw execption.

The only situation where throwing an exception seems to be of value is when someone needs to make sure that all inputs are signable. But "unsignable" inputs return None in other cases such as unrecognized script, and the check can be accomplished just by iterating over psbt.inputs doing if inp.sign(...) is None:

I think I will just replace raise ValueError(...) with return None in both cases: #53

Let me know if you think that there's a better way to handle this

from python-bitcointx.

From my view, I think returning None is right. A caller can always inspect the SignResult object to check (I think?) that the result is as intended. I believe I agree also about index; I don't have such a use case right now, but I could maybe imagine it.

from python-bitcointx.

I released v1.1.1.post2 with the fix

from python-bitcointx.