Giter Club home page Giter Club logo

Comments (5)

dgpv avatar dgpv commented on August 16, 2024

The distro-installed version of libsecp is unlikely to have experimental modules enabled, so anyone who would want to use schnorr sigs will need to compile themselves anyway (until the module becomes non-experimental, at least), so I'm inclining towards combining the options 2 and 3.

from python-bitcointx.

dgpv avatar dgpv commented on August 16, 2024

The safest is the option 4, of course. But there's no timeline when such stabilization would happen, AFAIK.

from python-bitcointx.

dgpv avatar dgpv commented on August 16, 2024

We could make enabling the scnorr signature support explicit with some function, like enable_experimental_schnorrsig_support(). Calling that function will be the indication that the caller is aware of the issue and is certain that the compatible version of the library will be loaded (kinda mirroring the libsecp 'experimental modules' concept)

from python-bitcointx.

scgbckbone avatar scgbckbone commented on August 16, 2024
  1. is too heavy imo; and I would say that anyone playing with this lib can compile for themselves so 2. seems pretty reasonable (update README to state what is the minimal version that one needs); 3. works already so why changing it and to 4. I'm also waiting for release but cannot find any info on timeline - meh

from python-bitcointx.

dgpv avatar dgpv commented on August 16, 2024

The chosen path is:

  • stating the 'recommended' commit in README.md (this change is already in master)
  • experimental modules must be enabled explicitly with allow_secp256k1_experimental_modules() or PYTHON_BITCOINTX_ALLOW_LIBSECP256K1_EXPERIMENTAL_MODULES_USE=1 environment variable (this change is in taproot branch)

from python-bitcointx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.