PSBT: is finalized state queryable? about python-bitcointx HOT 4 CLOSED

I do it like this:

    def extract_transaction(self) -> CTransaction:
        sign_result = self.sign(KeyStore())
        if not sign_result.is_final:
            raise ValueError(
                'not all inputs have required signatures')

This also does the consistency checks along the way.

It may be a bit wasteful if you only want to know if final_* fields were set, but adding is_final() method that would only do self.final_script_witness or self.final_script_sig is not in the spirit of the library ("consistency where possible/reasonable").

Do you thinkg a convenience is_final() that does self.sign(KeyStore()).is_final() would be useful ?

from python-bitcointx.

Maybe take the final_script_witness and final_script_sig check logic from sign() into is_final() and call is_final() from sign().

from python-bitcointx.

Check out #46 (untested at the moment), what do you think ?

from python-bitcointx.

is_final() will be included in 1.1.1.post1, along with a fix to restore expected set_utxo(None, ...) semantics.

#46 passes tests, but could benefit from some review, nevertheless.

from python-bitcointx.