Comments (3)
Hey thanks for reporting! Might be a performance regression (already had two of those iirc, might be time for some performance tests 🙈).
This function from typescript
being very slow was the problem last time so I added memoization.
If neither you nor someone else would be able to drill down on this, it'll probably take me some time to get to this, maybe next week.
from prettier-plugin-organize-imports.
Hm ok by just looking at the code a bit, i think I might have figured it out already. findTsConfig
gets the path of the file being formatted, which obviously is different for every execution (unless you format the same file twice), so the memoization never really does anything (when I introduced the memoization, it did fix the performance problem though 🤔).
from prettier-plugin-organize-imports.
@simonhaenisch Is not it better to find all tsconfig paths and just use search inside of the array and use most similar path. How much performace cost has findConfigFile
?
Btw, findConfigFile in typescript is not optimal at all if used for more than couple files
from prettier-plugin-organize-imports.
Related Issues (20)
- Sorting behavior inconsistent with prettier HOT 3
- How to disable this plugin? HOT 1
- Prettier 3 support HOT 3
- Cannot find module 'typescript' when adding this plugin to .prettierrc HOT 2
- Bug or feature? Once I type blank line between imports, imports are sorted within that group HOT 2
- Unable to auto-format imports in Vue SFCs HOT 4
- New typescript 5.0.0 `export type *` syntax not supported HOT 2
- Feature request: configurable import sort order HOT 3
- How to disable this plugin explicitly? HOT 1
- Imports may get removed if using Prettier range-start/range-end options HOT 22
- Sorting does not work if newline between imports HOT 1
- Imports get removed on save HOT 2
- Organize imports in Angular standalone components HOT 1
- Adding this plugin breaks github actions HOT 2
- Sort default imports and named imports HOT 1
- I would like to ask the author, this plugin collation and later support custom collation? HOT 1
- Using this plugin can be devastating for some types HOT 2
- Support for CommonJS HOT 1
- import 'reflect-metadata'; Needs to be the first/top import to work HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prettier-plugin-organize-imports.