Giter Club home page Giter Club logo

Comments (3)

simonhaenisch avatar simonhaenisch commented on May 25, 2024

Hey thanks for reporting! Might be a performance regression (already had two of those iirc, might be time for some performance tests 🙈).

module.exports.findTsconfig = memoize((path) => ts.findConfigFile(path, ts.sys.fileExists));

This function from typescript being very slow was the problem last time so I added memoization.

If neither you nor someone else would be able to drill down on this, it'll probably take me some time to get to this, maybe next week.

from prettier-plugin-organize-imports.

simonhaenisch avatar simonhaenisch commented on May 25, 2024

Hm ok by just looking at the code a bit, i think I might have figured it out already. findTsConfig gets the path of the file being formatted, which obviously is different for every execution (unless you format the same file twice), so the memoization never really does anything (when I introduced the memoization, it did fix the performance problem though 🤔).

from prettier-plugin-organize-imports.

XantreDev avatar XantreDev commented on May 25, 2024

@simonhaenisch Is not it better to find all tsconfig paths and just use search inside of the array and use most similar path. How much performace cost has findConfigFile?
Btw, findConfigFile in typescript is not optimal at all if used for more than couple files

from prettier-plugin-organize-imports.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.