Giter Club home page Giter Club logo

cwp-starter-theme's People

Contributors

assertchris avatar bergice avatar brettt89 avatar chillu avatar clarkepaul avatar dependabot[bot] avatar elliot-sawyer avatar emteknetnz avatar github-actions[bot] avatar guysartorelli avatar lexakami avatar mark-a-j-adriano avatar masseyisaako avatar matias-silverstripe avatar maxime-rainville avatar newleeland avatar nightjar avatar pjayme avatar raissanorth avatar robbieaverill avatar sabina-talipova avatar sachajudd avatar scopeynz avatar

Stargazers

avatar avatar avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

creative-commoners jishnucq gordonbanderson wobblyfrogs lexakami firesphere lexsusdk silverstripe-superchargers pamcez laocyberspaces huub-l luckyconnections9 sachajudd unclecheese open-sausages brynwhyman witschko jp96201 andreeverts strikerx121 silverstripeltd mark-a-j-adriano i3waitematadhb textagroup omulebadjoker cyberflamego nz-digital joshmens heartlandtechie

cwp-starter-theme's Issues

CompositeField_holder does too much

It implements the entire field, which is what the Field call is for. This results in subclasses (not to be confused with children) never having a chance to render themselves correctly.

e.g. SelectionGroup is supposed to render a list, as evident by the SelectionGroup template. However, when called in a template it will (as with all form fields) render in it's _holder template, ultimately resulting in no ul or li elements ever being rendered (by nature of Field being cut out of the holder template).

This in turn causes unit test failures in SilverStripe\Forms\Tests\SelectionGroupTest.

Banner block layout is not correct

With silverstripe/recipe-content-blocks installed the included banner styling on a blocks page does not display correctly when you have a background image and a link:

image

Main landmark must not be contained in another landmark (in blog pages)

Starter 3.0.x-dev

Main landmark must not be contained in another landmark

Issue description: Ensures the main landmark is at top level

Impact: moderate

Element location: .blog-main
Element source: <div class="blog-main" role="main">

To solve this violation, you need to fix the following:
The main landmark is contained in another landmark.

Matching second issue from the Axe checker:

Issue description: Ensures the document has only one main landmark and each iframe in the page has at most one main landmark

Impact: moderate

Element location: html
Element source: <html class="no-js" lang="en-NZ">
To solve this violation, you need to fix the following: Document has more than one main landmark

Related nodes: #main, .blog-main

Add support for content blocks (elemental)

The four SilverStripe supported block types:

  • Content: dnadesign/silverstripe-elemental
  • Form (user form): dnadesign/silverstripe-elemental-userforms
  • Banner: silverstripe/silverstripe-elemental-blocks
  • File: silverstripe/silverstripe-elemental-blocks

Pull requests

Give page templates a fluid container, and page layouts a fixed container

This change would not present any visual difference from the current state, but would allow developers to implement fluid containers in individual page layouts (by virtue of natural inheritance) if required.

Currently a page layout inherits a fixed container width, so to implement a fluid container you need to adjust it in the page template and then implement fixed containers in each page layout as well - adds duplication.

Fluid container (Bootstrap): class="container-fluid"
Fixed container (Bootstrap): class="container"

wrong scss files referenced in inspector

Not sure if this is related to the theme or laravel mix.

When inspecting elements in chrome the styles tab will display the styles for an element with a link to the scss file where these styles are located. However these references are completely wrong.

For example when I inspect the HTML element:
image

Clicking the link takes me to the file and line suggested but there is no HTML element defined at this position:
image

Update column grid offsets to match new Watea designs

Designs:

A/Cs:

  • Pages with content and sidebar should have no offset, and span the full 12 columns
  • Pages with content and sidebar should have a one column offset on the sidebar
  • Pages with content only should span 8 columns and have a 2 column offset
  • Changes are made in the starter theme
  • The Wātea theme correctly inherits these (or necessary override adjustments are made)

cc @silverstripeux

Add some behat tests for customised functionality

We should add some behat tests for the customised functionality in the theme. For example:

  • Navigation tabbing with keyboard
  • Dropdowns in navigation for sub-pages
  • Mobile view for navigation
  • Mobile and desktop search (although this would require Solr to could be too hard basket)
  • Filtering CWP news and events by date or tag
  • Bootstrap form validation plugin (form.js)
  • Sitemap: expanding sub-nodes

Add npm linting and built dist file comparisons to Travis

Many of the core SilverStripe modules with notable frontend assets now have npm linting and build dist file comparisons in Travis to ensure that (A) new changes lint correctly, and (B) that the dist files are correctly rebuilt.

We should add this as a single build step for the CWP themes.

Registries "Search results for School" grid template

Features - Registries - "Search results for School table" - (Select) School link

When using the registry module the data displays full width instead of using bootstrap grid templating. - An example from the CWP demo site.

image

Required fields are no longer alerting to the eye

Form fields with (validation) errors on them highlight with a red border and error message in the SilverStripe 3.x compatible versions.

In the SilverStripe 4.x release line however the red is gone (both text and input border), and the error messages blend in with the background and are easily missed.

Old (screenshot from CWP 1.8 install):
image

Elemental Banner Block template not applying

With CWP 2.1.0-beta1 it includes the new elemental block modules:

silverstripe/elemental-bannerblock
silverstripe/elemental-fileblock

This means the custom template for banner blocks is not being applied in 2.1.0

The directory names need to be updated (namespacing) but should we create a copy or rename the existing and add composer constraints? If constraints, which ones? The elemental modules are not required as part of cwp/installer but they are part of kitchen sink...

Note that it looks fine without the template, the template just adds some accessibility attributes.

Remove "Category icon" drop-down field

In the "Home" page type, under the "Features" tab, the "Category icon" drop-down field does not work and should be removed as it is not required in the themes.

Note: This is only an issue in the Starter theme, not Watea.

CMS-
image

Output-
image

cc @clarkepaul

Aside must not be contained in another landmark

All starter theme versions.

Axe report:

Aside must not be contained in another landmark. Ensures the complementary landmark or aside is at top level. [Fix the following:] The complementary landmark is contained in another landmark.
Element location
.footer-social-links
Element source
<div class="footer-nav-links footer-social-links col-auto" role="complementary">

Switch from Laravel Mix to use Webpack

To follow in line with SilverStripe 4 modules, we could perhaps switch this and the Wātea theme to use Webpack directly (possibly with the silverstripe/webpack-config module too) instead of using the Laravel Mix wrapper around it.

Up for discussion - Laravel Mix is pretty easy to use, so maybe it's not worth it.

[3.0 + IE10/Safari] HTML5 date picker fields do not work

Starter 3.0.x-dev with IE10

IE10 does not support HTML5 date picker components, which we've started to use in the frontend for filtering CWP events.

It renders as a text field.

We may need to add a jQuery datepicker shim or something for IE10 only.

Can be reproduced with the CWP demo site content on /en_NZ/event-holder and use the "Filter by date" form.

Tabbed interface does not exist when multiple authenticators are enabled

I've reproduced this on starter, Wātea, and simple themes and I'm not sure which one it is appropriate to raise an issue on.

In SilverStripe 3, when you enable additional authenticators the Security/login form would present you with a default login and a tabbed interface of alternatives. When you enable multiple authenticators on a SilverStripe 4 site (such as Active Directory, BootstrapMFA, or any of its derivatives), you're presented with an unordered list of authenticators with no way to visually tell them apart. A developer can customise it, but it would be nice to present a nicer default view

Starter

authenticators-starter

Wātea

authenticators-watea

Checkbox validation partially applies when browsing to previous user forms page

Steps to reproduce

  • Create a user-form required checkbox on a page that's not the first page
  • View that userform and proceed to the page with the checkbox
  • Before ticking the checkbox, browse to the previous page
  • Browse forward again to the page with the checkbox
  • Observe the label is highlighted to indicate an invalid state but the message explaining the state is not shown

Notes

I'm pretty sure this is to do with our custom validation JS in this module. This could be a problem with userforms though.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.