signum-network / sips Goto Github PK
View Code? Open in Web Editor NEWThis project forked from poc-consortium/cips
Signum Improvement Proposals
License: The Unlicense
This project forked from poc-consortium/cips
Signum Improvement Proposals
License: The Unlicense
The table that lists all CIPs as an overview can be updated.
As recently proposed (and already running experimental implementation) in SIP50 it could be interesting to add a web socket communication for P2P communication. This FR does not provide any technical details yet,... but I will analyze how P2P works and check how to enhance the API using WS.
The motivation is similar to SIP50. We might expect a lightweight event driven full-duplex communication which should be usually favored over common request/response communication.
Hardfork is planned soon. I suggest that a more serious consideration be given to reducing the new block minting time from 4 minutes to 2 minutes.
Advantages and reasoning:
Please consider my proposal thoroughly before HardFork is launched.
Current changes were already made but they are not included in SIP:
Add extended API:
GET_CURRENT_BALANCE: gets the asset quantity for the asset id in B2 (or SIGNA if B2==0)
GET_TYPE_FOR_TX_IN_A = 0x0305: document the getType values (maybe part of SIP37?)
Add new API
GET_ASSET_CIRCULATING = 0x040f; // EXT_FUN_RET total circulating supply of tokens of asset ID in B2
Note: I do not know how to format for SIPS.
Request NFT: add tokens and SIGNA flow to owner.
This would be to take an existing token and include it with a unique NFT graphic that says how many tokens are included. And when the token sends out dividends then the NFT smart contract passes the received SIGNA to the NFT owner's SIGNA address.
Not sure about royalties or platform fees.
I suggest that a more serious consideration be given to allowing token descriptions to be mutable.
As previously stated by ohager this is a protocol change.
Hope consider my suggestion thoroughly before a hard fork is launched.
I propose that we expand the SRC-44 descriptor to include a new OPTIONAL
property that refers to a "country code" in the description field structure.
The key would be labeled as ctry
and the value would be just an ALPHA-2 Country code
https://www.iban.com/country-codes
These would be the properties
Field Name | Required | Full Name | Value Format | Example | Rules | Description |
---|---|---|---|---|---|---|
ctry | NO | Country Code | string | US | A valid ALPHA-2 country code | A string property which can help a profile expand its digital identity |
As a subscription platform, we should also consider showing the description
and interval
of expired/cancelled subscriptions
The current way to fetch expired/canceled subscriptions is by fetching the transactions
with type=21
and subtype=4
As you can see on the response payload, the attachment
property. description
and interval
is missing.
{
"type": 21,
"subtype": 4,
"timestamp": 278363698,
"deadline": 1440,
"senderPublicKey": "7158e2e1170f9a3e1799ba4069ab55fac3d2242db5c0a08faf91c8b7cac3cb1f",
"amountNQT": "0",
"feeNQT": "2000000",
"signature": "b3db293e1fe637feda63ad9229cb3d6fbfa3afb4b6f104dd2b1c90e0d093130378d8acc6f7add947cebbc669d24ffbd700909f506376529b1cc117ebeb0e1e7f",
"signatureHash": "d5cc652417775a8ff35a9b9845b1b389eefeb9012684e2cc297c7a32cebb5a24",
"fullHash": "db68ec363e0b6e2af925056151ae37da50c2a0d843652730dd035ead5c9dc56d",
"transaction": "3057393558868486363",
"attachment": {
"version.SubscriptionCancel": 1,
"subscriptionId": "10561777840324094517"
},
// ...Remaining Transaction objects
}
It means the only way of getting the description
and interval
of canceled subscriptions is by making another getTransaction request.
Suggestion:
We can consider extending the attachment
property
"attachment": {
"version.SubscriptionCancel": 1,
"subscriptionId": "10561777840324094517",
"subscriptionDescription": "SRC44 DESCRIPTION OF CANCELLED SUBSCRIPTION",
"subscriptionInterval": "0000000",
}
Benefits:
Adjust the fee for asset (token) issuance to 150000 * FEE_QUANT from 15000 * FEE_QUANT
Currently the token creation is being abused by bad actors with offensive names and illegal acts and sending them to people unsolicited. It wasn't abused before the token issuance fee was lowered.
This causes a bad name for SIGNUM. And will drive people away.
Here are some names and their creators, not all offensive but some are the same as real coins past and present.
Not sure what the one that starts with Y even means.
As the modernization of the alias framework will allow STLDs, is necessary to make update on the specifications table:
https://github.com/signum-network/SIPs/blob/master/SIP/sip-44.md#specification
As we can appreciate in the alias
field, the rule
column shows an outdated one, it should be a regex expression that support STLDs
Solution
The regex expression can be updated to the following:
^(\w+)(?:\.(\w+))?$
Additional context
According to devina.io redos-checker
It states that the statement is safe
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.