sidofc / leather Goto Github PK

This project seems awesome.

Does it also work in browser?

It would be awesome, if we could retrieve data such as number of frames in animated png or webp, is something like that planned?

Thank you.

I found a bunch of more SVG files where the size is read wrongly. It results in { width: 0, height: 0 } in these:

wrong-dimensions-1.svg
wrong-dimensions-2.svg

package.json still shows 2.1.5, while NPM has a 3.0.0 release

I tested with these two files, and both cause issues currently:

https://kdrive.infomaniak.com/app/share/505458/af1779c8-11db-4bcf-8e39-55d791d8401d
https://kdrive.infomaniak.com/app/share/505458/3f1cdb78-b7b7-44b4-83a1-a094c022be52

The first one is identified as mp4, but doesn't find the width and height:
{ width: 0, height: 0, size: 19282849, mime: 'video/mp4' }

The second one isn't event found to be an mp4:
{ width: 0, height: 0, size: 0, mime: undefined }

This library is great and exactly what I am looking for, but sadly it assumes the data is in a file, which isn't the case in my scenario. A big advantage of image-size is that it supports buffers, but sadly doesn't handle videos. Why can't we have both? :)

I found some MP4 files where the size is read wrongly. It results in { width: 0, height: 0 } in these:

If the SVG data contains a <rect> element with width and height attributes, these values will be wrongly used as the width and height of the whole SVG, due to extractWidth() and extractHeight() running the following regular expressions on the full data, instead of just the top-level SVG node:

function extractWidth(data) {
    const matches = data.match(/width=(["'])([^%]+?)\1/i);

    if (matches) return parseDimension(matches[2]);
}

function extractHeight(data) {
    const matches = data.match(/height=(["'])([^%]+?)\1/i);

    if (matches) return parseDimension(matches[2]);
}

Attached an example of an SVG where the wrong dimensions are extracted.

test-1.svg

Oh and last feedback for now: I find attributes a bit strange and too generic as an import that one would use in the context of a broader project, because it does not indicate that it's a method reading something or returning something. It sounds like the name of a local variable. I therefore import it like this:

import { attributes as readMediaAttributes } from 'leather'

Something to think about...

Originally posted by @lehni in #9 (comment)

Sometimes it crash on trying to determine resolution on buffer (quite hard to reproduce)

RangeError: Attempt to access memory outside buffer bounds
    at new NodeError (node:internal/errors:405:5)
    at boundsError (node:internal/buffer:86:11)
    at Buffer.readUInt8 (node:internal/buffer:254:5)
    at readMediaAttributes (/app/dist/apps/api/node_modules/leather/dist/extractors/jpg.cjs:20:29)
    at readMediaAttributes (/app/dist/apps/api/node_modules/leather/dist/index.cjs:66:40)

it's crashing on this line https://github.com/SidOfc/leather/blob/master/src/extractors/jpg.js#L18
I guess its because sometimes buffer size is smaller then its expected in the code and we need additional check

While in SVGs, the dimensions appear to be rounded, I am getting strange floating point values for some videos, e.g.:

The get-media-dimensions package does this, and also supports MP3s and other audio files:

https://github.com/noblesamurai/get-media-dimensions

It would be quite nice to have this property as well.