sidadventist / sid_hymnal Goto Github PK

Song Numbers should match actual Adventist Hymnal numbers

Issue
On Android, after the audio ends, the stop button does not update back to play.

Expected behavior
The stop button must update and switch back to a play button when audio ends.

We need collaborators who can assist us with adding the more languages for the Christ In Song Hymnal.

Currently the Hymnal App has the following languages already completed:

• English
• Tswana
• Xhosa

For more details read Contributing Translations

Have a look at what the dark mode looks like...

Search by Hymn Number or Option to go directly to Hymn Number

This issue is part of the solution for #30.

It is very straight-forward and clear for anyone willing to help. We need to add a matching Advent Hymnal Number where available in Christ in song.

The file you will be working on is /assets/cis-ah.json.

The structure is in JSON Format. Simple put it is as follows:[

{
    "1":"368",
    "3":"206",
    "4":"442",
    "6":"598",
    "7":"218",
    "8":"216"
}

1. On the left hand side of the colon you put the Christ in Song Hymn number, in quotes
2. On the right hand side of the colon you put the Advent Hymnal number, in quotes as well
3. You add a comma before new number pair.

You can edit the file directly in the browser, or you can manually fork the repo, clone it to your computer and work on it.

Describe the bug
Hymn 36 shows lyrics and audio What a fellowship instead of My Faith Looks Up

Expected behavior
Hymn 36 should be My Faith Looks Up

The contrast of color is still a bit weak (in iOS 13 dark mode) . The icons in blue on gray are not too visible in dark mode. White on black or gray seems better see example of what's up.

I like the project and wanted to contribute , after forking the project and running it. I am encountering so many errors.

Note:

• Using Flutter 3
• I undated all packages to Major/Latest Versions
• Run the dart fix --apply command.

ISSUES FOUND
Steps to reproduce the behavior:

1. The get_version package has been discontinued.
2. The dart fix -apply command only fixes null safety nulls
3. The new List (); (in a Future Builder is is not working)
4. Overall the codebase needs to be updated.

Expected behavior
For the project to run smoothly with Flutter 3 < 3+

Screenshots