Giter Club home page Giter Club logo

shosetsu's People

Contributors

abidin24 avatar blatzar avatar doomsdayrs avatar hxtreme avatar jobobby04 avatar khonkhortisan avatar mikodafreako avatar regenerate38 avatar roshavagarga avatar technojo4 avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

shosetsu's Issues

[ENHANCEMENT] Overhaul of UI schema

Main theme

  1. Custom colors
  2. Adjustable sizes

Overhaul reader

  1. Change text color separately
  2. Change background color separately
  3. Have 3 'default' colors. Light, Night, Sepia

[Bug] Crash on markdown reader selection

Describe the bug
App crash on markdown reader selection while reading

To Reproduce
Steps to reproduce the behavior:

  1. Read any chapter
  2. Open menu, Reader, Markdown
  3. Crash

Expected behavior
Reader changes

Device information:

  • OS: LDPlayer 3.76
  • App Version: v1.0.0

[BUG] Back button behaviour

Please see the video

Ideal behaviour on pressing back button on the following screen: (incomplete list)

Screen Behaviour
Library Exit App
Settings, Download... Goto Library
Sub-settings Goto Settings

F-Droid Support

Hello,

Have you considered applying to have Shosetsu added to F-Droid?

[Bug] Color of text

Screenshot_20190802-232720_Shosetsu

When you bookmark a chapter and remove the bookmark the color doesnt restore properly.

[Bug] Chapters dont resume

Trying to read books and I noticed that it says POSITION so I assume it keeps track where you left off in a chapter.

It doesn't seem to resume for me. Position number is 42962 with a short chapter. Not sure how I bugged out here.

Also. Adding a button for easy resuming VS finding the chapter I left off on. I'm starting a 1000+ chapter series and scrolling down to find my chapter would be a bit cumbersome.

Using takiyomi as a reference they have a play button to continue reading.
Screenshot_20190803-134309_Tachiyomi

Screenshot_20190803-133517_Shosetsu

[UI] Border in Library

Please check the video there you see that when library is scrolled down the animation has borders and is not going from edge to edge of the screen/view.

[BUG] Parsing leaves a div tag

Chapters of Release that Witch from Box Novel is surrounded by div tag.

The same also happens with every other ln I've tried from Box Novel.

Screenshot_2019-07-11-04-30-25-143_com github doomsdayrs apps shosetsu

APP CRASH WHEN TRY TO OPEN NOVEL

EXPECTED BEHAVIOR

this application will open the novel well so that users can read whatever novels they want

ACTUAL BEHAVIOR

when the user wants to open a novel to read, before the novel is fully loaded this application will stop working and crash.

STEP TO REPRODUCE

  • download and install the app
  • open the app
  • click on tree line on the left side
  • click on catalogue
  • chose novel full or box novel
  • wait for a second and novel list will appear
  • then chose any novel you want to read
  • note the error

BUG RECORDING

https://youtu.be/iVlBxn0cJ_g

LOGCAT

Process: com.github.doomsdayrs.apps.shosetsu, PID: 3491
java.lang.RuntimeException: An error occured while executing doInBackground()
	at android.os.AsyncTask$3.done(AsyncTask.java:304)
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:355)
	at java.util.concurrent.FutureTask.setException(FutureTask.java:222)
	at java.util.concurrent.FutureTask.run(FutureTask.java:242)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:231)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
	at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.NoSuchMethodError: No static method encodeBase64String([B)Ljava/lang/String; in class Lorg/apache/commons/codec/binary/Base64; or its super classes (declaration of 'org.apache.commons.codec.binary.Base64' appears in /system/framework/ext.jar)
	at com.github.doomsdayrs.apps.shosetsu.backend.database.Database.serialize(Database.java:126)
	at com.github.doomsdayrs.apps.shosetsu.backend.database.Database.access$000(Database.java:54)
	at com.github.doomsdayrs.apps.shosetsu.backend.database.Database$DatabaseChapter.addToChapters(Database.java:464)
	at com.github.doomsdayrs.apps.shosetsu.backend.async.NovelLoader.doInBackground(NovelLoader.java:86)
	at com.github.doomsdayrs.apps.shosetsu.backend.async.NovelLoader.doInBackground(NovelLoader.java:42)
	at android.os.AsyncTask$2.call(AsyncTask.java:292)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	... 4 more```

[Bug] Chapters not showing as READ

Screenshot_20190804-010702_Shosetsu

Title.

When I'm done reading a chapter I back out to start the next one and it always shows a high position and "reading"

It's fixed by going back in and scrolling to the very bottom and backing out again.

[Bug] [v1.0.0-dev-rc2] crash on download screen

Not sure how to replicate.

Queue 200 chapters to download on one LN.

Refresh another LN while downloading.

Hangs. Doesn't load second LN.

Check download screen crashes.

Reopen app. crashes on downloads screen again.

Redownload 1st LN. Wait till done.

Downloads opens fine empty.

[UI] New ICON for app

In recent years interface design paradigm has been moving towards flat icons and interface and to better align with this consider removing shadows and borders from the following:

Screenshot_2019-07-11-00-44-28-662_com github doomsdayrs apps shosetsu
Screenshot_2019-07-11-00-45-08-157_com github doomsdayrs apps shosetsu

At the same time also consider smaller font size for ln title in catalogue.

Consider checking out Material design guidelines.

[Suggestion] Batch downloading

currently the only way to download for offline reading is to click one at a time or use the inefficient "select between" to download a bunch at once. Since you're using takiyomi as a reference for design and flow they have it setup at "Download next 10" which is a quick and easy way to download a bunch or a sample of a novel.

so far great work!
ZomboDroid_02082019234948
Takiyomi process pic. Menu, Download, Options!

crash when try to open the app

EXPECTED BEHAVIOR

this application should be able to open properly so that users can use this application properly

ACTUAL BEHAVIOR

this application will fail to open when the user wants to open and use it!

STEPS TO REPRODUCE

  • download and install the app
  • open the app and note the error

BROWSER

DEVICE: OPPO NEO 6
OS : ANDROID 6.1

BUG RECORDING

https://youtu.be/2OViVMDLWRk

NOTE

seem like the issue appear caused xml built
seem like the problem on this line
Caused by: java.lang.RuntimeException: A TaskDescription's primary color should be opaque

Process: com.github.doomsdayrs.apps.shosetsu, PID: 3505
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.github.doomsdayrs.apps.shosetsu/com.github.doomsdayrs.apps.shosetsu.MainActivity}: java.lang.RuntimeException: A TaskDescription's primary color should be opaque
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2525)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2617)
	at android.app.ActivityThread.access$800(ActivityThread.java:182)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1474)
	at android.os.Handler.dispatchMessage(Handler.java:111)
	at android.os.Looper.loop(Looper.java:218)
	at android.app.ActivityThread.main(ActivityThread.java:5657)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.lang.reflect.Method.invoke(Method.java:372)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:990)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:785)
Caused by: java.lang.RuntimeException: A TaskDescription's primary color should be opaque
	at android.app.ActivityManager$TaskDescription.<init>(ActivityManager.java:555)
	at android.app.Activity.onApplyThemeResource(Activity.java:3764)
	at android.view.ContextThemeWrapper.initializeTheme(ContextThemeWrapper.java:140)
	at android.view.ContextThemeWrapper.setTheme(ContextThemeWrapper.java:85)
	at android.support.v7.app.AppCompatActivity.setTheme(AppCompatActivity.java:90)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2465)
	... 10 more```

[Minor Bug] FooBar

Every file has foobar written instead of Shosetsu in disclaimer.

/*
 * This file is part of Shosetsu.
 * Shosetsu is free software: you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 * Foobar is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU General Public License for more details.
 * You should have received a copy of the GNU General Public License
 * along with Shosetsu.  If not, see https://www.gnu.org/licenses/ .
 * ====================================================================
 * Shosetsu
 * 9 / June / 2019
 *
 * @author github.com/doomsdayrs
 */

Foobar is distributed in the hope that it will be useful

[Bug] chapters don't load

Process
Open novelfull
Search title
Overgeared and "I alone level up" tested
Refresh to load into.
Description loads
Chapter list does NOT. Although it looks like it downloads.

ZomboDroid 21122019143308

[Suggestion] next chapter button

When done reading one has to back out and scroll down to the next chapter VS a "Continue" button.

Bonus points to ensuring it marks the current chapter you're on as read.

[Suggestion] "Continue reading" button

Picking up where you left off can be a chore with longer novels that have hundreds of chapters.

A resume reading option would be nice!

Takiyomi for reference

Screenshot_20190803-134309_Tachiyomi

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.