@kevinhughes27
/cc @Shopify/apps @Shopify/security

Please see: https://github.com/Shopify/security-incidents/issues/19

Your docs reference this: https://shopify.dev/docs/admin-api/rest/reference/shipping-and-fulfillment/fulfillmentservice?api[version]=2020-04

but you're using https://shopify.dev/tools/embedded-app-sdk which is marked as deprecated. Is there a more up to date example?

shopify.Order.find( fulfillment_status="fulfilled") does not return orders with fulfillment_status="fulfilled" at all.

Instead it does return only None or partial

When running 'bundle exec rake test' it looks like the testing framework that was being used has been deprecated and it fails to run any tests and just outputs warnings about how the tests should be upgraded :\

$ bundle exec rake test
/usr/bin/ruby2.1 -I"lib:test" -I"/var/lib/gems/2.1.0/gems/rake-10.1.1/lib" "/var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb" "test/__test.rb"
Warning: you should require 'minitest/autorun' instead.
Warning: or add 'gem "minitest"' before 'require "minitest/autorun"'
From:
/usr/lib/ruby/2.1.0/test/unit.rb:1:in require' /usr/lib/ruby/2.1.0/test/unit.rb:1:in<top (required)>'
/home/ben/public_html/shopify-fulfillment-integration/test/test_helper.rb:4:in require' /home/ben/public_html/shopify-fulfillment-integration/test/test_helper.rb:4:in<top (required)>'
/home/ben/public_html/shopify-fulfillment-integration/test/app_test.rb:1:in require' /home/ben/public_html/shopify-fulfillment-integration/test/app_test.rb:1:in<top (required)>'
/var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:10:in require' /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:10:inblock (2 levels) in

'
/var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:9:in each' /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:9:inblock in '
/var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in select' /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in'
MiniTest::Unit::TestCase is now Minitest::Test. From /usr/lib/ruby/2.1.0/test/unit/testcase.rb:8:in <module:Unit>' /usr/lib/ruby/2.1.0/test/unit.rb:676:inclass:Runner': undefined method _run_suite' for classTest::Unit::Runner' (NameError)
from /usr/lib/ruby/2.1.0/test/unit.rb:261:in <module:Unit>' from /usr/lib/ruby/2.1.0/test/unit.rb:15:inmodule:Test'
from /usr/lib/ruby/2.1.0/test/unit.rb:7:in <top (required)>' from /home/ben/public_html/shopify-fulfillment-integration/test/test_helper.rb:4:inrequire'
from /home/ben/public_html/shopify-fulfillment-integration/test/test_helper.rb:4:in <top (required)>' from /home/ben/public_html/shopify-fulfillment-integration/test/app_test.rb:1:inrequire'
from /home/ben/public_html/shopify-fulfillment-integration/test/app_test.rb:1:in <top (required)>' from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:10:inrequire'
from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:10:in block (2 levels) in <main>' from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:9:ineach'
from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:9:in block in <main>' from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:inselect'
from /var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb:4:in `'
rake aborted!
Command failed with status (1): [ruby -I"lib:test" -I"/var/lib/gems/2.1.0/gems/rake-10.1.1/lib" "/var/lib/gems/2.1.0/gems/rake-10.1.1/lib/rake/rake_test_loader.rb" "test/__test.rb" ]

Tasks: TOP => test
(See full trace by running task with --trace)

Just dropping a second issue on top of the one from 3 years ago.

Can this example be redone with the new Remix app framework and new Fullfilment guidelines?

Trying to implement a simple dropshipping app integration with Shopify and it's a mess of misleading information, and confusing documentation / examples.

As this is cited as example code for teaching new developers this should use the built in ShopifyApp::WebhooksManager rather than directly calling Webhook.new(). It is much too easy for developers to go off and roll there own hook solution that isn't as good as WebhooksManager if they don't know it exists, potentially building something that causes problems down the road when their home grown hook doesn't use a queue and times out.

Edit: I would make a patch that changes it to use WebhooksManager, but I am not entirely sure the correct way to do that (my current project is just more copy/paste of more web hooks from the example, but I recognize that it is bad and should be changed) so I have made a pull request to at least mention it so others will be aware of it earlier when just reading over the code.

Edit2: Along the same lines I am not sure if I have done something wrong, but the install is never called so I now just call it explicitly inside of '/', was the install/uninstall deprecated a while back in favor of something like WebhooksManager?