web-foundation repository
This project has migrated to thePlease follow that repository for updates and bug reports
Tools to help us wrangle images at Shopify.
Please follow that repository for updates and bug reports
Hi guys
I used this module inside polaris package. But can't find anyway to use custom svg file instead use default limited icon provided in this package
How i can fix it
Given the SVG file:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="224" height="224" viewBox="0 0 224 224">
...
When SVGO optimizes the file and removing dimensions, viewBox
is being removed alongside with width
and height
which result into the icon-loader.js error:
Error: icon.svg
Module build failed: TypeError: Cannot read property '1' of null
at Object.shopifyIconLoader (~/node_modules/@shopify/images/icon-loader.js:14:50)
Optimized file looks like:
<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink">
Add {removeViewBox: false}
to the optimize.js
to prevent viewBox
from being removed.
1st party software must have a business impact classification. See our list of classification to help you determine the classification of your application.
It's critical that we understand the business impact of the software we write. The classification of your service determines the level of support you must provide as owners and helps us set standards.
This is mandatory. If this is not done you won't be able to have any runtimes.
At the latest, this should be done before 2021-07-22.
First, leave a comment explaining why it doesn't apply. Then, leave another comment as /not_applicable
, and close the issue.
If you change your mind, make sure to comment any reason and reopen the issue.
Please contact the Production Excellence team using Slack at #production-excellence-team.
Your service: images/production
Owners:
A declarative, efficient, and flexible JavaScript library for building user interfaces.
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. ๐๐๐
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google โค๏ธ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.