Feature regression relating to the OnFileMatched event about shokoserver HOT 5 CLOSED

This is likely related to the issues with importing anime in the new queue. The cross-references are already made when it's matched, and the episodes should be available at this point.

@da3dsoul can correct me if I'm wrong.

from shokoserver.

It's possible. I cannot confirm or deny without experimenting

from shokoserver.

Just quickly confirming... I continue to get this behaviour in the most recent build, 6f910d9.

A trimmed log is available as per the below (with the errors thrown by my own plugin being initially triggered by the OnFileMatched event).
example.log

from shokoserver.

@fearnlj01 starting in ecc1917 you can use the IReadOnlyList<IVideoCrossReference> CrossReferences on the IVideo to check if the cross-references has been made, and also get the episode ids to look out for in the episode updated event (when filtering the UpdateReason Reason to UpdateReason.Added or UpdateReason.Updated on the event), if the episodes are empty on the file matched event data. I don't think we can guarantee that the episode/anime metadata is available when the matched event is dispatched, but now you can at least react to it.

Alternatively since IReadOnlyList<IVideoCrossReference> CrossReferences has also been added to the IEpisode interface then you can store the video ED2K hashes that didn't have the episode events, then later in the episode updated event look for them to "resume" what you were going to do once the cross-references were available.

Either way, it should be even easier to handle when the cross-references are made but before the episodes are added now compared to before.

from shokoserver.

I don't think we can guarantee that the episode/anime metadata is available when the matched event is dispatched

In hindsight, it's more surprising that this information was seemingly always available given when you would logically expect a file match event to be fired.

The alterations as you've described should be more than enough to suit my needs.

Unless there were any plans on deferring the OnFileMatched event to a point in time after cross references are acquired (which wouldn't really make sense...) then I can't see any reason that this issue would remain open, so I'll close this as a happy resolution.

Thanks for the changes!

from shokoserver.