Giter Club home page Giter Club logo

decimalnonassign's Introduction

decimalnonassign

Go linter that checks if the result of a decimal operation is assigned

supported package: https://pkg.go.dev/github.com/shopspring/decimal

Motivation

The arithmetic methods in github.com/shopspring/decimal are immutable. The result must therefore be assigned to a variable. If no assignment is made, unexpected situations are more likely to occur.

func sample() decimal.Decimal {
  result := decimal.Zero
  result = result.Add(decimal.NewFromFloat(2)) // ok
  result.Add(decimal.NewFromFloat(1)) // oops, Value not updated...๐Ÿ’€

  return result
}

Usage

package main

import "github.com/shopspring/decimal"

func calledDecimalMethodInRange() {
	ds := []decimal.Decimal{decimal.NewFromFloat(2), decimal.NewFromFloat(2), decimal.NewFromFloat(2)}

	result := decimal.Zero
	for _, d := range ds {
		result = result.Add(d)
		result.Add(d)
	}
}

Analysis

$ decimalnoassign ./...
./a.go:11:10: The result of 'Add' is not assigned

Installation

go install github.com/sho-hata/decimalnonassign/cmd/decimalnonassign@latest

Contribution

  1. Fork (https://github.com/sho-hata/decimalnonassign/fork)
  2. Create a feature branch
  3. Commit your changes
  4. Rebase your local changes against the master branch
  5. Run test suite with the go test ./... command and confirm that it passes
  6. Run gofmt -s
  7. Create new Pull Request

License

MIT

Author

sho-hata

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.