shmulik-kravitz / react-jewish-datepicker Goto Github PK

when i choosing another month or year is changing only the day but not the month and year.

even in the demo - https://react-jewish-datepicker.js.org/

Hi @sagi770 @yochanan-sheinberger @akraines

We wad like to replace the package hebcal that is licensed GPL-3 with jewish-date that is licensed with MIT.

In order to change the license of this project from GPL-3 to MIT we need everyone who donated code to approve.

Can you please approve?

In order to approve, please respond to this issue with:

Approved

Thank you all for donating code to the project.

Shmulik

i have forked this repo to customize it but when i try to install using npm i faced error so when i tried to install original repo with npm i faced same issue
command: npm i https://github.com/Shmulik-Kravitz/react-jewish-datepicker/tarball/master
error: npm ERR! Cannot read properties of undefined (reading 'spec')

כשבוחרים תאריך בחודש אדר התאריך שמופיע הוא באדר א' ולא אדר סתם.
אפשר לראות בדמו https://react-jewish-datepicker.js.org/

1. when clicking outside the date picker it does not close. you have to pick a date or click on the picked date. it's annoying.
2. when changing the value using setState etc. the picked date does not update correspondingly:
   this code works. bot when i update greg with setGreg there is no effect on the date picker.
   const [greg, setGreg] = useState(date.greg());

<ReactJewishDatePicker value={greg} isHebrew onClick={(day) => { handleDatePicker(day); }} />