Indexing new valuesets adds unique documents instead of updating existing with the same __NodeId about examine HOT 8 CLOSED

I've never tried that before but the problems will be:

• Deleting a document is by __NodeId so it will delete them all
• Querying on __NodeId I suspect is expecting a single result but you will get more than one, not sure what will happen

It kind of goes against the contract of what Examine expects so I'm not really sure the consequences.

from examine.

Everything is based on valueSet.Id to add or update the document behind the scenes. What is the Id you are passing here? And if it is the same Id, and a new document is being added that would seem pretty strange. There's tests in the codebase here to testing updating docs which work, so does seem odd.

from examine.

Hmm on further testing it seems to be unrelated to v4. I get the same problem with v3.1.0.

I will try to reproduce on a fresh site and link the repo.

from examine.

I've set up a repo where I can reproduce the issue running Examine 3.1.0: https://github.com/jemayn/examine-duplicates

Steps:

1. Build the product index, should have 4 documents:
   
2. Add a "new" product with a matching id to one of the existing ones but a new name by calling the test api controller at https://localhost:44358/umbraco/api/test/updatevalues
3. Check the index, it now has 5 documents - two of them with id 1:
   

from examine.

Are you using "__NodeId" as the key?

from examine.

I am calling it like this:

private readonly IExamineManager _examineManager;
private readonly ProductIndexValueSetBuilder _productIndexValueSetBuilder;

public TestController(IExamineManager examineManager, ProductIndexValueSetBuilder productIndexValueSetBuilder)
{
    _examineManager = examineManager;
    _productIndexValueSetBuilder = productIndexValueSetBuilder;
}

public void UpdateValues()
{
    if (!_examineManager.TryGetIndex(IndexingConstants.IndexName, out var index))
    {
        return;
    }

    var product = new Product
    {
        Id = 1,
        Name = "Name with update 1"
    };
    
    index.IndexItems(_productIndexValueSetBuilder.GetValueSets(product));
}

And the valueset builder looks like this:

public class ProductIndexValueSetBuilder : IValueSetBuilder<Product>
{
    public IEnumerable<ValueSet> GetValueSets(params Product[] products)
    {
        foreach (var product in products)
        {
            var indexValues = new Dictionary<string, object>
            {
                [UmbracoExamineFieldNames.NodeNameFieldName] = product.Name,
                ["id"] = product.Id
            };

            yield return new ValueSet(
                product.Id.ToString(),
                IndexingConstants.IndexType,
                IndexingConstants.IndexType,
                indexValues);
        }
    }
}

So I am setting the string Id param in the ValueSet constructor to product.Id.ToString() which seems to set it in the __NodeId field. I also tried adding it as a specific field, but then it gets added twice like this:

from examine.

I think its because you are overriding the field type of the key __NodeId here

https://github.com/jemayn/examine-duplicates/blob/baee007649996924b8451155c9929750712457de/Indexing/ProductIndexOptions.cs#L33

from examine.

Ohhh hadn't considered that not all fields need to be explicitly set.
I tried removing that line and now it works as expected! Thanks!

On a similar note, is it problematic in any way to have multiple index documents with the same id?

Say fx you had products and they had multiple language versions, would there be any benefits to doing it like this:

__NodeId: 1
nodeName: Product 1
description_da-dk: Description in Danish
description_en-gb: Description in English

Versus this:

__NodeId: 1
nodeName: Product 1
culture: da-dk
description: Description in Danish

__NodeId: 1
nodeName: Product 1
culture: en-gb
description: Description in English

from examine.