Giter Club home page Giter Club logo

Comments (5)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 13, 2024
Thanks for reporing. You are right that it should have been replaced by the 
value of the CMake variable in gflags_declare.h . In the .cc files, the #define 
in the internal config.h is used, however. The idea is simply not to add to 
many gflags library related #defines to the public headers.

Original comment by [email protected] on 26 Mar 2014 at 7:29

  • Changed state: Accepted
  • Added labels: Milestone-v2.1.1

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 13, 2024
This issue was closed by revision 38213112a57f.

Original comment by [email protected] on 26 Mar 2014 at 7:37

  • Changed state: Fixed

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 13, 2024
This issue should be fixed. Before the next (bugfix) release, I will make sure 
to add a test which uses gflags_declare.h only which would have avoided these 
fixes.

Original comment by [email protected] on 26 Mar 2014 at 7:38

  • Changed state: Testing

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 13, 2024
This issue was closed by revision 38213112a57f.

Original comment by [email protected] on 27 Mar 2014 at 1:31

  • Changed state: Fixed

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 13, 2024
This issue was updated by revision dc8543a47385.

Added a test which uses gflags_declare.h as any other project would use it to 
avoid such avoidable build configuration mistakes.

Original comment by [email protected] on 30 Mar 2014 at 2:16

from gflags.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.