Comments (5)
Thanks for reporing. You are right that it should have been replaced by the
value of the CMake variable in gflags_declare.h . In the .cc files, the #define
in the internal config.h is used, however. The idea is simply not to add to
many gflags library related #defines to the public headers.
Original comment by [email protected]
on 26 Mar 2014 at 7:29
- Changed state: Accepted
- Added labels: Milestone-v2.1.1
from gflags.
This issue was closed by revision 38213112a57f.
Original comment by [email protected]
on 26 Mar 2014 at 7:37
- Changed state: Fixed
from gflags.
This issue should be fixed. Before the next (bugfix) release, I will make sure
to add a test which uses gflags_declare.h only which would have avoided these
fixes.
Original comment by [email protected]
on 26 Mar 2014 at 7:38
- Changed state: Testing
from gflags.
This issue was closed by revision 38213112a57f.
Original comment by [email protected]
on 27 Mar 2014 at 1:31
- Changed state: Fixed
from gflags.
This issue was updated by revision dc8543a47385.
Added a test which uses gflags_declare.h as any other project would use it to
avoid such avoidable build configuration mistakes.
Original comment by [email protected]
on 30 Mar 2014 at 2:16
from gflags.
Related Issues (20)
- Add ability to have options that can be specified multiple times. HOT 2
- Please put the label 'google' on this project HOT 5
- Warnings in Visual Studio 2010 and unable to compile unit test HOT 10
- Can't locate auto/Autom4te/XFile/msg.al in @INC HOT 2
- How to set kRootDir for FlagValue::CleanName
- Support NuGet package generation for Windows users HOT 1
- @GFLAGS_IS_A_DLL@ expands to empty string in gflags_declare.h HOT 6
- Set INTERFACE_COMPILE_DEFINITIONS of imported gflags library targets to define GFLAGS_DLL_DECL HOT 2
- Google glog fails to find gflags/gflags.h when using google namespace HOT 4
- Compilation error on Windows when trying to use the library. HOT 2
- Add library versioning (soname) HOT 6
- Import symbols into google namespace to maintain backwards compatibility HOT 10
- Flags always have default value HOT 1
- Bad soname version in current git master HOT 10
- Incorrect makefile generation with cmake HOT 1
- compile problem HOT 5
- Support uint32 as flag type
- ReloadNonCommandFlags needed HOT 2
- FindThreadsCXX error when cross-compiling HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gflags.