Giter Club home page Giter Club logo

Comments (6)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
Thanks for reporting. This mistake fall through the cracks as the header file 
is configured prior to settings GFLAGS_IS_A_DLL in the CMakeLists.txt. Also, if 
both libraries are being build, we will need to make a default choice for this 
on Windows. The exported CMake targets can have a property that specified which 
GFLAGS_DLL_DECL to use in this case.

To fix this issue, I modified the build configuration to always set 
GFLAGS_IS_A_DLL to 1 if BUILD_SHARED_LIBS is ON. You can of course always 
define GFLAGS_DLL_DECL yourself before including the header file, but as Unix 
user you should of course not have to.

Original comment by [email protected] on 25 Mar 2014 at 3:28

  • Changed state: Accepted
  • Added labels: Milestone-v2.1.1

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
This issue was closed by revision 09f7800768f8.

Original comment by [email protected] on 25 Mar 2014 at 3:30

  • Changed state: Fixed

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
This issue was closed by revision 6040eac5b357.

Original comment by [email protected] on 25 Mar 2014 at 3:30

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
Opened issue 78 for addressing the import definition of GFLAGS_DLL_DECL to help 
users/CMake set it properly if both shared and static libraries were 
build/installed.

Original comment by [email protected] on 25 Mar 2014 at 3:39

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
This issue was closed by revision 38c4402f58ad.

Original comment by [email protected] on 27 Mar 2014 at 1:31

from gflags.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 14, 2024
Issue 81 has been merged into this issue.

Original comment by [email protected] on 30 Mar 2014 at 1:43

from gflags.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.