sharkaboi / drawingsapp Goto Github PK

Describe the bug
Images don't get deleted on deleting marker. Only the Uri gets deleted but not the actual image in the disk thus leading to duplicates and waste of space.

To Reproduce
Steps to reproduce the behavior:

1. Add drawing
2. Delete drawing
   or
3. Add Marker with images
4. Delete marker.

Expected behavior
On deletion of drawing > All drawing image and all nested marker images should get deleted.
On deletion of marker > All attached marker images should be deleted,

Fix
Easy fix : Recursively check and delete for files as cached in room.
Tough Fix : Switch to content provider.

Describe the bug
ViewBinding's binding objects are not destoryed in fragments. They are not cleared and cause leaks.

To Reproduce
Steps to reproduce the behavior:

1. Go to Any fragment.
2. Go home and close app.
3. Dump and analyse heap in leak canary.

Expected behavior
No leaks should happen.

Fix
Set all _binding objects in fragments to null in onDestroyView().