shamblett / aloha Goto Github PK

Hi,

This is a friendly request to ask that if you get back into this code, that we recommend using dart:js instead of package:js. We've found that package:js can greatly increase the size of the generated JavaScript. The dart:js library does not have this effect.

Meanwhile, your pubspec.yaml is great: it locks to a specific version of package:js. Future versions of package:js will not be backwards compatible.

Please feel free to reach out if you have any questions.

Thanks!

The CDN the tests have been using has vanished, either find a new one, download and server a local copy or retire the package.

Update Aloha so all exception strings are declared in the AlohaExceptions class

Tests 9,10,11 and 15 in group 1 fail when the test suite is run, if however Dartium is refreshed the tests all work, they form that point onward no matter how many times Dartium is refreshed.

Investigation reveals that although the code in boht Dart and JS seems to work, the editableActivatedEvent and editableDectivatedEvent don't seem to fire on first invocation of test suite.

It is not known if this is Aloha itself or some effect of Dartium, the version of Aloha being used is the same as at the 2.0.0 release, however Dart is now 1.6, not 1.0.

Documented this behaviour in the test docs for now.