Changing the workbench license about freecad_fastenerswb HOT 51 OPEN

waiting for response of:
@riqueenz, @FreeCAD-Tools, @luzpaz, @hasecilu, @berberic2, @Roy-043, @EA32, @elysium31, @kaktusus, @wavexx, @tobiasfalk, @easyw, @fra589, @wandrewkeech, @algtgv, @hpbmo, @chennes, @ApexArray, @JohanAR, @elf128, @chrido, @spike77453, @yorikvanhavre, @f3nix

from freecad_fastenerswb.

@FreeCAD-Tools is a man from Ukraine. We all know the current situation in that country. Give him some time. 😞

from freecad_fastenerswb.

Thanks for ping, it's nice to know that this WB could join upstream FreeCAD.
I agree with the license change, I'm also in for SheetMetal WB.

from freecad_fastenerswb.

@tobiasfalk I could be talking out of my arse, but I vaguely recall that @sliptonic and @shaise were in agreement that the unfolder shoud definitely be part of the core and thus be rewritten in C++. Once/if the relicensing of both WBs has green lights, there definitely should be review of both architecture, workflow, and UX/UI to come up with a sensible plan.

from freecad_fastenerswb.

(Copy the main post)

- [X] @shaise
- [X] @alexneufeld
- [X] @riqueenz
- [ ] @FreeCAD-Tools
- [ ] @luzpaz
- [X] @hasecilu
- [ ] @berberic2
- [X] @Roy-043
- [ ] @EA32
- [ ] @elysium31
- [X] @kaktusus
- [X] @wavexx
- [X] @tobiasfalk
- [ ] @easyw
- [X] @fra589
- [ ] @wandrewkeech
- [ ] @algtgv
- [X] @hpbmo
- [ ] @chennes
- [ ] @ApexArray
- [ ] @JohanAR
- [ ] @elf128
- [ ] @chrido
- [ ] @spike77453
- [ ] @yorikvanhavre
- [ ] @f3nix

from freecad_fastenerswb.

I'm all for re-licensing to LGPL2.1, this is also compatible with @ulrich1a screw_maker license which the original WB was based on.

from freecad_fastenerswb.

Hi all,
I just made an action to correct a bug linked to the evolution of Python and FreeCAD, I do not feel entitled to decide on the licensing level...
Do as your wish :-)
Thanks for your work!

from freecad_fastenerswb.

@hasecilu, Thanks! great idea!

from freecad_fastenerswb.

No objection to the license change (and I think distributing this with FreeCAD would be a good idea :) )

from freecad_fastenerswb.

No objections, I'm barely a contributor to this project anyway :)

from freecad_fastenerswb.

I have no issues with the idea of doing this. Taking a quick look through the repository contributors list, I'd say there's a good chance we can get everyone to sign off on a license change to LGPL. I agree that this change fits well within the philosophy of the FreeCAD project.

For potentially useful reference: I like the approach the MPV player developers took to tackling this exact problem: mpv-player/mpv#2033

from freecad_fastenerswb.

@alexneufeld That's a really useful reference, thank you!

from freecad_fastenerswb.

I've been working on the Polish translation of this cool workbench, and I don't mind changing the license. 😄

from freecad_fastenerswb.

I have no objections to the LGPL2.1 license.

from freecad_fastenerswb.

I have also no objections to the LGPL2.1 license.

from freecad_fastenerswb.

Thanks for pinging, I wouldn't have noticed otherwise. No objection to the license change!

from freecad_fastenerswb.

In my opinion, my share of contribution is rather small and do not think that I would have a saying in this.
But I do not have a problem with this.

@prokoudine will there be an other Issue/Thread where one could give Suggestion of features that would be nice if they where implemented in this move to an Integrated workbench? This is since the most intelligent think to do, while moving this to FreeCAD, is to rewrite the core of this workbench in C++/Qt.

from freecad_fastenerswb.

No objection to the license change!

from freecad_fastenerswb.

And can either @prokoudine or @shaise make a check list with all the pinged people to make it easier to look up who already agreed?

• A
• B
• ....

from freecad_fastenerswb.

Works for me! 👍

from freecad_fastenerswb.

from freecad_fastenerswb.

I do not mind the change.
Cheers,
Mateusz

from freecad_fastenerswb.

No objection to the license change!

from freecad_fastenerswb.

No objections to the license change 👍

from freecad_fastenerswb.

No objections.

from freecad_fastenerswb.

No objection

from freecad_fastenerswb.

That is O.K. for me.

from freecad_fastenerswb.

Sorry to be late 😅 I agree!

from freecad_fastenerswb.

go for it!
sorry being late, but I don't watch very often my GH notifications

from freecad_fastenerswb.

FYIO: What git blame thinks about the missing user.
This is not a comprehensive analysis!

EA32 419 lines in 18 files
    GrammaticalTools.py:25
    InitGui.py:1
    FsData/gost1144head.csv:42
    FsData/gost1144length.csv:2
    FsData/gost1144range.csv:2
    FsFunctions/FSmakeWoodScrew.py:104
    Icons/ASMEB18.2.1.6.svg:14
    Icons/ASMEB18.21.1.12B.svg:11
    Icons/ASMEB18.3.5C.svg:12
    Icons/DIN508.svg:26
    Icons/GN507.svg:49
    Icons/GOST1144-3.svg:33
    Icons/GOST1144-4.svg:33
    Icons/ISO4014.svg:14
    Icons/ISO4028.svg:12
    Icons/ISO7089.svg:11
    Icons/ThreadedRod.svg:14
    Icons/ThreadedRodInch.svg:14

FreeCAD-Tools 1922 lines in 34 files
    TRANSLATIONS.md:73
    GrammaticalTools.py:41
    FastenerBase.py:29
    FastenersCmd.py:35
    README.md:4
    ScrewMaker.py:2
    translations/fasteners_pt-br.ts:182
    translations/fasteners_pt-pt.ts:182
    translations/fasteners_ru.qm:39
    translations/fasteners_ru.ts:885
    translations/update.sh:43
    translations/fasteners_es-ar.ts:137
    translations/fasteners_es-es.ts:137
    FsData/DiaList.csv:2
    FsData/din571length.csv:19
    FsData/gost1144length.csv:29
    FsData/gost1144range.csv:22
    FsData/gost11860def.csv:15
    FsFunctions/FSmakeCupNut.py:1
    FsFunctions/FSmakeWoodScrew.py:1
    Icons/ASMEB18.3.1A.svg:17
    Icons/ASMEB18.3.5A.svg:11
    Icons/ASMEB18.3.5B.svg:11
    Icons/ASMEB18.5.2.svg:13
    Icons/DIN96.svg:16
    Icons/GOST1144-1.svg:19
    Icons/GOST1144-2.svg:19
    Icons/GOST11860-1.svg:12
    Icons/ISO4026.svg:11
    Icons/ISO4027.svg:11
    Icons/ISO4762.svg:16
    Icons/PCBSpacer.svg:17

elysium31 0 lines in 0 files 0

wandrewkeech 0 lines in 0 files

elf128 0 lines in 0 files

from freecad_fastenerswb.

from freecad_fastenerswb.

@berberic2 ,
I do not know how blame works but @elysium31 had several PRs. @wandrewkeech and @elf128 had one.
Perhaps their work was overwritten?
Even so, they still count.
waiting for @FreeCAD-Tools and @EA32 as well

from freecad_fastenerswb.

As I said: This is not a comprehensive analysis!
blame gives for every line the last user that commited this line, so changing the indentation or whitespaces is sufficient.

from freecad_fastenerswb.

from freecad_fastenerswb.

@elf128 , thanks! noted!
@berberic2 , as I said perhaps their lines are no longer in the code, but they did contribute.

from freecad_fastenerswb.

If their changes are still there, we would proceed by removing them. So If their code changes are no longer present than we can proceed without their reply.

from freecad_fastenerswb.

git shortlog --author=FreeCAD-Tools --author=EA32 --author=elysium --author=keech

from freecad_fastenerswb.

@FreeCAD-Tools is a man from Ukraine. We all know the current situation in that country. Give him some time. 😞

Or am I in the wrong?

from freecad_fastenerswb.

Hi! Sorry been afk on github for quite some time.
This is great and fully support the license cha!nge

from freecad_fastenerswb.

great!
Waiting for @FreeCAD-Tools , @EA32 and @elysium31

from freecad_fastenerswb.

No objections

from freecad_fastenerswb.