shadowmoose / poe-aura-calc Goto Github PK

Line 224:

'#% Physical Damage Reduction': {scaling: 1},

Change to

'#% additional Physical Damage Reduction': {scaling: 1},

That way it'll parse in POB correctly

Also Defiance banner

Buff grants #% increased Evasion Rating and Armour

needs to be
"#% increased Evasion Rating and Armour"

change 'https://raw.githubusercontent.com/brather1ng/RePoE/master/data/gem_tooltips.min.json'
to 'https://raw.githubusercontent.com/brather1ng/RePoE/master/RePoE/data/gem_tooltips.min.json' in data.js

Currently doesn't work unless you make that change

https://aura.poe.farm/ tried multiple browsers

I believe it should be 'Additional Physical Damage Reduction' which parses correctly and seems to have the same effect.

I noticed that my clarity buffs were a few points off and did some digging.

Regeneration rates are stored per minute which means they can have non-integer per second values.

Right now poe-aura-calc converts to an integer per second value first and then applies aura modifiers which means the final value ends up being a bit smaller than you see in game or in POB.

I think the easiest fix would be to not convert to per second until after the buffs; and when you do, don't use floor since the in game value will not be floored. For visual clarity, it'd probably be fine truncated to 1 or 2 decimal places (POB uses 2).

I think this change caused most aura stats to become decimals when some aura effect is introduced, which PoB doesn't accept for anything but the "per-second" stats that were fixed.

With the addition of the royale mode there are some royale-balanced versions of auras that share the same name as the ones for the main game, messing up the calculator. The only discernible ways I found to tell which one is the royale version are:

• The key (AccuracyAndCritsAura vs AccuracyAndCritsAuraRoyale)
• The base['base_item']['id'] value ("Metadata/Items/Gems/SkillGemPrecision" vs "Metadata/Items/Gems/SkillGemPrecisionRoyale")
• The size of base['per_level'] (40 for the main version, 10 for the royale version)

Hi , Please update

https://www.poewiki.net/wiki/Defiance_Banner

"Now grants Nearby Enemies have (30-40)% reduced Critical Strike Chance (previously 20–29%)."

now DB can give reduce crit as base buff . . .

3.19 update

RePoE's gem data, https://raw.githubusercontent.com/brather1ng/RePoE/master/RePoE/data/gems.min.json
is structured completely differently and will require quite a bit of work to update to new format.
Can use legacy source 'https://raw.githubusercontent.com/brather1ng/RePoE/a40af396ecd2b9391a3a14aead7987298c62b799/RePoE/data/gem_tooltips.json'
until update to allow continued function with old values (mainly Vitality changed + alt quality potential)