Giter Club home page Giter Club logo

harbour-twablet's People

Contributors

nokius avatar sfietkonstantin avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

harbour-twablet's Issues

Quick tweet configurability

Allow the quick tweet function to be hidden, at least on the phone. Should be determined by a configuration switch.

Load more

We should be able to load more tweets in a timeline

Be able to cancel a retweet

hi sfietkonstantin, the latest version is great. thx.
one thing i noticed is, i retweet a random post. If I revert the retweed.all is wrking fine. but if I want to retweet once again the same tweet then it's not longer possible. nothing dramatically. only feedback purposes.

Reading tweets

We should be able to click on a tweet to read it: open it in the side panel, fully expanded

Reliable unit tests

We need some reliable unit-tests that covers most of the code.
The observable observer pattern, and variations in repositories is rather fragile.

Tweets multiple times in stream

Not sure if this bug is related to issue #31, but sometime tweets are multiple times in the stream.

I found a way to reproduce it:
refresh and before the refresh is done trigger a refresh again. The mount of triggered refreshes you will see the tweets in the stream.

may a solution is to wait with an refresh until the last one is done to avoid this issue.

A better cover

A better cover could be nice. It might display the number of unread tweets in total, plus the columns having new tweets.

[feature]

a scroll to top option would be nice. Take me a lot of time to sroll up to the latest tweet... :-)

Separate tweet cache between accounts

Now the whole tweet cache is shared between all acocunts. It means that if one account RT / Fav a tweet, it will be shown as RT / Faved for every account.

The cache should split tweets based on accounts.

Keyboard for Pin Activation

The Keyboard for the Activation process shows Enter. Is it possible to change this to the hide. I pressed Enter after I typed my Pin but the keyboard didn't disappeared, So I had to swipe it away to proceed on the phone.

Add new column

We should be able to support any query type when adding a new column

Load more button for friends and followers not working

During the test for #53 I found out that the Button to 'Load more' is not working correct for friends/following and followers. It's not loading more friends/following and follower.

here some output

[D] UserCentralRepository::load:108 - Request: "followers/list.json" (count:200, cursor:0, include_user_entities:true, skip_status:true, user_id:2473600839)
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 1 ""
[D] private_util::RepositoryProcessCallback::operator():109 - New data available. Count: 0
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 0 ""

[D] UserCentralRepository::load:108 - Request: "friends/list.json" (count:200, include_user_entities:true, skip_status:true, user_id:15066760)
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 1 ""
[D] private_util::RepositoryProcessCallback::operator():109 - New data available. Count: 200
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 0 ""
[D] UserCentralRepository::load:108 - Request: "friends/list.json" (count:200, cursor:0, include_user_entities:true, skip_status:true, user_id:15066760)
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 1 ""
[D] private_util::RepositoryProcessCallback::operator():109 - New data available. Count: 0
[D] qml::Model::setStatusAndErrorMessage:224 - Current status 0 "

Option to save pictures

I think it would be nice to be able to save pictures from tweets to local storage.

Note: This most probably requires issue #22 to be implemented first.

Possible ways of triggering the picture-save action:

  • long pressing the image (this is how the Sailfish OS browser currently does it)
  • pull down menu action in image detail view (once implemented)

Where should the pictures be saved ?
Just saving the pictures in the ~/Pictures folder would be a good start (and the same thing the default Sailfish OS browser does). A possible improvement could be saving the picture to a twablet subfolder to not pollute the toplevel Pictures folder like the browser currently does - tracker should still grab it even if it is in a subfolder.

Later more advanced methods of selecting the destination would be nice to have, such as:

  • being able to override the default picture saving destination
  • being able to select the destination when saving the picture to allow sorting of saved pictures to separate folders

RT, fav and reply

When reading a tweet, we should be able to RT, favorite and reply to the tweet.

time lable is wrong

The information about the time of the tweet is minimum 2h but it's just a few minutes old. This happen for both streams.

Saved Search

When adding a new search column, it could be nice if saved search were displayed

List info

We should be able to display list information

Doc

Document the code

Search panel

A panel where new search can be sent. Open results in the same panel.
The result can then be added as a column.

Hashtag rendering issue

If there are two hashtags that starts with the same text (like #Jolla #JollaTablet), the shorter one will be highlighted twice.

Orientation lock

There should be an orientation lock, landscape on tablet, portrait on phone.
Enabling or disabling can be done via settings

old 'code' in the project

after my catch from last night 86acee

I found more 'old' code, I found out that UserPage.qml shows 'friends' not followers.

grep -r 'friends'
src/tests/tst_tweetrepository.cpp: user.insert(QLatin1String{"friends_count"}, 789);
src/tests/tst_tweetrepository.cpp: user.insert(QLatin1String{"friends_count"}, 56);
src/bin/translations/harbour-twablet-de.ts: %1's friends
src/bin/translations/harbour-twablet-de.ts:friends
src/bin/translations/harbour-twablet-de.ts: No friends
src/bin/translations/harbour-twablet.ts: %1's friends
src/bin/translations/harbour-twablet.ts:friends
src/bin/translations/harbour-twablet.ts: No friends
src/bin/qml/pages/RightPanel.qml: title: qsTr("%1's friends").arg(screenName),
src/bin/qml/pages/UserPage.qml: text: query.user ? qsTr("%n\nfriends", "", query.user.friendsCount) : ""
src/bin/qml/pages/UsersPage.qml: errorMessage: (model.status === Model.Idle && model.count === 0) ? qsTr("No friends") : ""
src/lib/query.h: * @ brief Query the list of friends of an user (following)
src/lib/qml/userobject.h: Q_PROPERTY(int friendsCount READ friendsCount CONSTANT)
src/lib/qml/userobject.h: int friendsCount() const;
src/lib/qml/userobject.cpp:int UserObject::friendsCount() const
src/lib/qml/userobject.cpp: return m_data.friendsCount();
src/lib/usercentralrepository.cpp:#include "friendsqueryhandler.h"
src/lib/friendsqueryhandler.cpp:#include "friendsqueryhandler.h"
src/lib/friendsqueryhandler.cpp: return QLatin1String{"friends/list.json"};
src/lib/user.cpp: m_friendsCount = json.value(QLatin1String("friends_count")).toInt();
src/lib/user.cpp:int User::friendsCount() const
src/lib/user.cpp: return m_friendsCount;
src/lib/CMakeLists.txt: friendsqueryhandler.cpp
src/lib/user.h: int friendsCount() const;
src/lib/user.h: int m_friendsCount {0};

Just changing the visible (to the user) Strings will may be more like a hot fix and make the project harder to maintenance.

Saved search management

When adding a new search column, it could be nice to be able to add or remove saved searches

Indicator glitch

When in landscape, the right bar on top of toolbar (the indicator) do not indicate the correct columns when there are too many of them (larger than the size of the toolbar)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.