sfhardman / kong-plugin-zipkin Goto Github PK

Hello!

Good job on the plugin! We are happy to see members of the community stepping forward and publishing Kong plugins on Luarocks :)

As of now, we don't offer you yet a way to advertise your plugin on https://getkong.org/plugins, but are planning to in the future. In the meantime, feel free to publish an announcement on the Kong Mailing List, as I am sure it will give you some exposition and peak the interest of some Kong users out there.

[ANN] Community Plugin - kong-plugin-zipkin [plugin version]

What do you think?

Best,
Thibault

https://github.com/Kong/kong/blob/master/UPGRADE.md#upgrade-to-012x

"In logging plugins, the request.request_uri field has been renamed to request.url"

Thanks for contributing to the Kong community by creating and maintaining this plugin!

I wanted to let you know that Kong CE will soon include a bundled Zipkin plugin Kong/kong-plugin-zipkin#5

As such, you may want to consider what you'll do with your Zipkin plugin going forward - of course, you could continue to maintain it, or you could consider lending your efforts to improving the plugin I linked to above - or all of the above :)

Thanks again!

Right now, it appears this plugin supports the v1 format. It would be nice if it supports the simplified v2 format going forward.

The v2 format is described in the Zipkin server's API documentation: https://zipkin.io/zipkin-api/#/default/post_spans

without this line i got kong.plugins.zipkin.zipkin is not found.

https://github.com/sfhardman/kong-plugin-zipkin/blob/master/kong-plugin-zipkin-0.1.0-1.rockspec#L29

Cannot decode spans due to IllegalArgumentException(VYc0IZ1GWo2xxJpz5ZufQK6TiNERv2pI should be a 1 to 32 character lower-hex string with no prefix reading List from json)

The value of property timestamp in variable formatted_trace would be the value of start_time because get problems for display bars of nested span when plugin is configured with sample_once_every_n_requests=1 and simulate_server=false.

We are currently considering using this plugin to integrate tracing from requests to Kong with the rest of our system. The readme has the following warning it in now.

This is proof of concept code, not production ready

What tasks/features are lacking currently for this to be production ready? If we could make that clear and track them here, people using this plugin and others in the community can more easily help make it production ready.

One thing I think I see by reading the code (though I'm not familiar with Kong or Lua at all) is it looks like it is sending the span data on each request instead of batching. I don't know how easy or possible it is, but batching sending spans could improve performance of reporting spans to Zipkin.

when I send a request cross the kong,the zipkin show the serviceName as the client ip,not the kong server ip,by the way,how can I set the kong's serviceName

There is a known issue (#6 ) submitting traces to a Zipkin2 instance over the v1 API (and the v2 API is not supported yet).