sferencik / sincity Goto Github PK

The teamcity-winservice log contains exceptions like "Could not find changes between ... and ...", coming from finishing (failing) builds triggered by SinCity.

This is because cancelled builds aren't considered part of the history (see SinCityUtils). Thus, if we run builds A (success), B (failures + cancelled), C (failures), then B will trigger SinCity for the (A, B) range and C will trigger it for the (A, C) range (because it ignores B in the history). As a result, (A, B) is investigated twice.

Currently, SinCity works around a TC problem whereby two logically equal ARTIFACT_DEPENDENCY_ERRORs aren't considered .equals(). See https://youtrack.jetbrains.com/issue/TW-43503.

This issue should be fixed in TC 10.

Make use of this fix. The current workaround is somewhat simplistic (see this file): it considers all the artifact-dependency errors identical. For TC 10 it could use the native handling, which is better.