PlayIdleAnimOnReload=1 Causes to lose highlighting after reload in combat about sfall HOT 1 CLOSED

I can't seem to reproduce that in my game. In a random encounter with two group of enemies fighting each other, I shoot someone and reload (playing "idle" animation), all critters still have their combat highlight (outlines) in subsequent turns.

EDIT: OK I got it. This specifically happens when the Target Highlight preference is in the default "targeting only".

Some boring technical details:
PlayIdleAnimOnReload inserts an animation sequence, and at the end of sequence it calls register_end() which invokes combat_anim_begin(). If the Target Highlight is targeting only (combat_highlight == 2), combat_anim_begin() will turn off highlights in combat.
So my fix is simple: force change the setting right before calling register_end() to avoid turning off combat highlights, then restore the setting afterward.

from sfall.