seuliang / pgapack Goto Github PK

I was tracking an erratic problem with a c++ program using pgapack. Turns out 
the problem is that pgapack uses ctx->sys.UserFortran uninitialized in 
PGACreate() in create.c.

Adding 'ctx->sys.UserFortran = PGA_FALSE;' right after the call to malloc() 
(i.e. after the NULL pointer check) fixes the problem.

Alternatively the call to malloc() can be replaced by a call to calloc().

The problem is very hard to reproduce as PGACreate() sets ctx->sys.UserFortran 
to PGA_FALSE if it has any value other than PGA_FALSE and PGA_TRUE. Therefore 
the bug is only exposed in rare cases.