setsun / react-transition-components Goto Github PK

Hello! First of all thank you for developing this library.

I was wondering if I can use it on my isomorphic page and once I installed the package I'm having a window undefined error from server. It seems that the dist/index.js file have an IFEE that injects the window as argument:

!(function(t, e) {
  if ('object' == typeof exports && 'object' == typeof module)
    module.exports = e(require('react'), require('react-transition-group'));
  else if ('function' == typeof define && define.amd) define(['react', 'react-transition-group'], e);
  else {
    var r =
      'object' == typeof exports
        ? e(require('react'), require('react-transition-group'))
        : e(t.React, t.ReactTransitionGroup);
    for (var n in r) ('object' == typeof exports ? exports : t)[n] = r[n];
  }
})(window, function(t, e) {

......
.......
......
.......

I think there's something wrong with this block but i havent really figured it out yet.

When a component mounts, it is in the "exited" state, but the startStyle is applied since exited = entering. This means when exited->entering->entered, the styles are actually startStyle->startStyle->endStyle, which means the transition only starts to take effect when we are in the entered state.

I've temporarily fixed this in my component by manually applying the exited styles on the child component (to force a transition basically), but I think we need to fix which style is applied when

See this issue: reactjs/react-transition-group#159

Probably need to implement an rAF in here somewhere

makes me angry!!!!!!

The API has changed for v2, investigate breaking changes and how transition components can be simplified.

Because why not? https://github.com/parcel-bundler/parcel

🚨 You need to enable Continuous Integration on all branches of this repository. 🚨

To enable Greenkeeper, you need to make sure that a commit status is reported on all branches. This is required by Greenkeeper because it uses your CI build statuses to figure out when to notify you about breaking changes.

Since we didn’t receive a CI status on the greenkeeper/initial branch, it’s possible that you don’t have CI set up yet. We recommend using Travis CI, but Greenkeeper will work with every other CI service as well.

If you have already set up a CI for this repository, you might need to check how it’s configured. Make sure it is set to run on all new branches. If you don’t want it to run on absolutely every branch, you can whitelist branches starting with greenkeeper/.

Once you have installed and configured CI on this repository correctly, you’ll need to re-trigger Greenkeeper’s initial pull request. To do this, please delete the greenkeeper/initial branch in this repository, and then remove and re-add this repository to the Greenkeeper App’s white list on Github. You'll find this list on your repo or organization’s settings page, under Installed GitHub Apps.

pls

Transition allows for CSS transitions via React inline-styles. This can remove a CSS file dependency and also allow us to more easily configure things like easing and duration via the component props.

This also fixes CSS specificity issues when using the CSS classes needed by CSSTransition.

In most cases the props will not change when configuring a component, so a decent perf win will be to memoize the result of all the function calls that generate inline-styles based on the props.

• lodash.underscore adds ~3 kb to the bundle, potentially see if implementing it locally is worthwhile

react-transition-group has some nice callback functionality like onEnter, onExit, etc for tracking transition states.

Would be nice to pass in an optional transitionId in the props of the choreography component which can allow us to track the current status of the transition by passing it through the callbacks, which will make coordinating multiple transitions much easier in the app state.