sethrobinson / rtdink Goto Github PK

The conversation where Dink tries to boast about his adventures to the bar patrons in Terris, and Milder walks in to humiliate him, can still occur even after Milder is supposed to have vanished into the Darklands, or died.

rabidwolf9 got a new controller for his phone (Flydigi Wee 2) in order to play games on the go psvita/switch style.

As it stands DinkHD isn't playable with this controller by default due to not being able to attack or talk/examine without stretching for touch controls.

The attack button binding is located at:

I couldn't find anywhere that the Proton Android platform code sets VIRTUAL_DPAD_BUTTON_DOWN, which means there is no way to attack with Android if I'm reading the code correctly.

The talk button binding is located at:

Proton sets VIRTUAL_DPAD_BUTTON_DOWN here:

https://github.com/SethRobinson/proton/blob/37eabc0cb500755c90fb229bf09d29744982d54c/shared/android/AndroidUtils.cpp#L1108

'case 4' is the Android keycode, so that is supposed to be translated into talking. But 4 is actually KEYCODE_BACK in Android-speak. Despite what the comment says, this doesn't seem to work.

http://www.dinknetwork.com/forum.cgi?MID=202835

The other day RobJ notified me that he was having trouble installing a dmod packed using my Martridge launcher - I decided to investigate the issue and today I found the problem...

First of all, in Martridge I use a modified version of SharpCompress to package dmods. (I changed the bzip2 algorithm in the original repo to use multi-threaded block processing ).

Before, I had only tested the packed dmods using tools like 7zip or winrar or the old DFArc V3 by Beuc. Since they worked in all of those, I was certain that my packed dmod file format was correct and bug free.

Anyway, it turns out, Sharp Compress does not use the "USTAR" format for its .tar files! Instead, it seems to use the old v7 header https://en.wikipedia.org/wiki/Tar_(computing)#Header

The problem is that the tar handler that DinkHD uses, proton\shared\util\archive\TarHandler.cpp only supports "USTAR" format, and not the older format.

Now that I know what the issue is, I'm thinking I should probably further modify my fork of SharpCompress to use the "USTAR" format for TARs, since it supports longer path names and it's just a better idea in general.

But on the other hand, I don't think DinkHD should refuse to work with the older v7 format either...

I also did a simple test, and it seems that commenting out these lines in Proton's TarHandler.cpp "fixes" the issue:

		if (strncmp(m_tarHeader.magic, "ustar", 5) != 0)
		{
			//bad header.  We probably need to push it forward by 512 bytes for some reason
			return WriteBZipStream(pData + 512, size - 512);
		}

Although I haven't studied how the code works too in depth right now and I can't say if this wouldn't break some sort of compatibility with "USTAR" format TARs...

I'll look into this the next few days and run some proper tests! For now I just wanted to let you know about the issue...

Hey Seth!

I've loved this game since I was a kid. I think I remember buying the CD directly from you via a PCmag or something. One unique thing I remember about it is that it has CD audio tracks on it. One of my all-time favorite games. I especially remember enjoying the Milli Vanilli mod.

My OS of choice at this point is Linux. Great coding environment and good for games to boot. Two-part question:

1.) Are you able to update the source for Linux?
2.) If and when you are, are you interested in giving permission to add it into the "libretro" library? Libretro, as you probably know, is an open source environment for game and media stations for all platforms. Essentially it would allow Dink Smallwood to be ported to Nintendo Switch, Kodi media centers, you name it, etc.

I could take a look into it myself. I'm a pretty shitty coder, but given the time and inspiration, I can do a few neat things. :)

Love your work! Thanks.