sergius02 / qrit Goto Github PK

When running 1.0.3 from the testing repo on a fresh install, I get this in the Terminal:

Failed to execute child process “qrencode” (No such file or directory)

It seems like you need to include qrencode as a dependency in your packaging. Please resolve this, create a new release on GitHub, and submit that release to the AppCenter Dashboard. As always, if you have any questions, feel free to ask here.

While reviewing your app I noticed that your appdata is missing a release tag for version 1.1.4 which you wanted to publish

The app send a notification when you try to save the QR code without specifying the name at the moment. However, I think it would be more kind to save the QR code with the default name (e.g. the placeholder of the name entry Awesome_QR.png) if a user don't specify the name.

As existing works, Screenshot does similar thing:

qrencode can generate:

PNG
EPS
SVG
ANSI
ANSI256
ASCII
ASCIIi
UTF8
ANSIUTF8

AppCenter tried to run appstreamcli validate on com.github.sergius02.qrit and
received the following errors:

W: com.github.sergius02.qrit:89: description-has-plaintext-url ul
I: com.github.sergius02.qrit:10: description-first-para-too-short Create awesome QR codes with QRit!

Validation failed: warnings: 1, infos: 1

For more information, see:

• The AppStream Quickstart Guide
• The AppStream Metadata Specification

Build Information

Affects Architecture: amd64
Affects Distribution: hera
Built with the following references:

• refs/tags/1.1.2

The cache folder of QRit is located at $HOME/.cache/com.github.sergius02.qrit/

If, for example, i create a PNG QR, and then SVG QR, the PNG is still in the cache folder.
If someone open a big text file and qrencode fails, QRit load by default the PNG that is in the cache folder. In this case an old QR.

Not sure what the limit for the amount of data a code can hold is, but AFAIK it's as detailed as the code can be
So it would be insane to be able to quickly scan a code and get all the text on my phone! I think that it would be useful for quickly copying small miscellanious text from elementary to your phone

Instead of sending the notification "You must enter a content to that QR!"

UI displays Cancelar and Abrir instead of English.

Is your feature request related to a problem? Please describe.

I wanted to generate a qr code for guests to join our home Wifi and found QRit in the elementary AppCenter. However, it seems I'm only able to enter an URL to generate a QR Code from. There is also the file open possibility, but I'm not sure what this is for and/or which file format is expected.

Describe the solution you'd like

It would be great to have an option in QRit to choose from different types. Once a type is selected, it would greatly help if QRit could show the input fields to enter the required information and afterwards generates a qr code from them.

Describe alternatives you've considered

There is https://www.qr-code-generator.com/ which allows me to create a qr code online by selecting the type of the qr code first. However, I'm not 100% confident to enter Wifi credentials into a website.

https://docs.elementary.io/develop/writing-apps/code-style

As you might have heard, AppCenter is going Flatpak! For elementary OS 6, we will not longer be accepting Debian packaging, so your app will need to be updated.

We have documentation on our developer guide for writing your Flatpak manifest here: https://docs.elementary.io/develop/writing-apps/our-first-app/packaging#flatpak-manifest

Also, in case you missed it, elementary OS 6 beta 2 is now available. This is a great time to get your app packaged up as Flatpak and test that everything is working before the final release. AppCenter submission for OS 6 will be open soon, so don't delay :)

Describe the bug

Currently QRit is adding a hole to its sandbox to access home. It looks like this permission is necessary because QRit is using the Gtk filechooser rather than the filechooser portal

To Reproduce
Steps to reproduce the behavior:

1. Open QRit
2. Select the open folder icon in the headerbar
3. See that this is GTK's file chooser rather than the file chooser portal

Expected behavior

Instead of creating a custom filechooser here, QRit should use FileChooserNative so that it can be more tightly sandboxed

Describe the bug
Spanish is used for some UI elements even when system language and the rest of the app is in English

To Reproduce
Steps to reproduce the behavior:

1. Click on 'open file' icon
2. What should've been 'cancel' and 'open' is now 'cancelar' and 'abrir'.

Expected behavior
A clear and concise description of what you expected to happen.

1. The buttons should be labelled in English instead of Spanish.
   Screenshots
   If applicable, add screenshots to help explain your problem.
   

Desktop (please complete the following information):

• OS: elementary OS 5.1.7 Hera