Giter Club home page Giter Club logo

Comments (5)

SergioBenitez avatar SergioBenitez commented on June 5, 2024 1

Yes, this is possible via magic. You can already mostly do this by using the magic Tagged value. It would be straightforward to implement a SelectedProfile type that can be used in place of the String in your example (the existence of such a type would also mean you can keep the string and use a serde attribute to convert the magic value into a String). I'll look into implementing this soon.

One problem with this idea - perhaps I've even implemented it before - is that any such value would only have meaning during extraction. It's not clear what you'd set the value to if you want to create the structure without an extraction, for example.

One alternative is to set the value yourself directly. That is, perform the extraction, and then set config.profile = figment.profile(). You can ask serde to skip deserializing the value so that it's not set during extraction. This is the approach Rocket takes, for example.

from figment.

SergioBenitez avatar SergioBenitez commented on June 5, 2024 1

Closing as this isn't really possible to implement with today's serde, and work-arounds (above) exist.

from figment.

ogarcia avatar ogarcia commented on June 5, 2024

Yes, the alternative you mention is the one I am using. I tell serde to ignore the profile variable in the structure and then assign it manually as you say, but it would be interesting (or more elegant) if the extract did it for you. In addition for what you comment this something that you also use in Rocket so it makes sense.

from figment.

SergioBenitez avatar SergioBenitez commented on June 5, 2024

Alright, so I looked into this, as I had already implemented this before. It's actually sitting in the magic module right now:

#[derive(Debug, Clone, PartialEq, Deserialize, Serialize)]
#[serde(rename = "___figment_selected_profile")]
pub struct SelectedProfile {
    profile: Profile,
}

/// TODO: This doesn't work when it's in a map and the config doesn't contain a
/// value for the corresponding field; we never get to call `deserialize` on the
/// field's value. We can't fabricate this from no value. We either need to fake
/// the field name, somehow, or just not have this.
impl Magic for SelectedProfile {
    const NAME: &'static str = "___figment_selected_profile";
    const FIELDS: &'static [&'static str] = &["profile"];

    fn deserialize_from<'de: 'c, 'c, V: de::Visitor<'de>>(
        de: ConfiguredValueDe<'c>,
        visitor: V
    ) -> Result<V::Value, Error>{
        let mut map = crate::value::Map::new();
        map.insert(Self::FIELDS[0].into(), de.config.profile().to_string().into());
        visitor.visit_map(MapDe::new(&map, |v| ConfiguredValueDe::from(de.config, v)))
    }
}

impl Deref for SelectedProfile {
    type Target = Profile;

    fn deref(&self) -> &Self::Target {
        &self.profile
    }
}

As the comment indicates, this works, but it has some downsides. In particular, as the comment indicates, any kind of nesting will fail:

#[derive(serde::Deserialize)]
struct Base {
    profile: SelectedProfile,
}

#[derive(serde::Deserialize)]
struct Testing {
    base: Base,
    value: usize
}

// This panics.
let testing: Testing = Figment::from(("value", 123)).extract().unwrap();

The issue is that there's no base field in the figment - magic only works at the top-level, since that's the only case in which serde asks to deserialize a SelectedProfile directly instead of asking to deserialize a Base.

As a result of this gotcha, I've opted to not included this functionality thus far.

from figment.

ogarcia avatar ogarcia commented on June 5, 2024

Completely true, I hadn't noticed that use case in which there is no profile.

from figment.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.