Comments (5)
Yes, this is possible via magic. You can already mostly do this by using the magic Tagged value. It would be straightforward to implement a SelectedProfile
type that can be used in place of the String
in your example (the existence of such a type would also mean you can keep the string and use a serde attribute to convert the magic value into a String). I'll look into implementing this soon.
One problem with this idea - perhaps I've even implemented it before - is that any such value would only have meaning during extraction. It's not clear what you'd set the value to if you want to create the structure without an extraction, for example.
One alternative is to set the value yourself directly. That is, perform the extraction, and then set config.profile = figment.profile()
. You can ask serde to skip deserializing the value so that it's not set during extraction. This is the approach Rocket takes, for example.
from figment.
Closing as this isn't really possible to implement with today's serde
, and work-arounds (above) exist.
from figment.
Yes, the alternative you mention is the one I am using. I tell serde to ignore the profile
variable in the structure and then assign it manually as you say, but it would be interesting (or more elegant) if the extract
did it for you. In addition for what you comment this something that you also use in Rocket so it makes sense.
from figment.
Alright, so I looked into this, as I had already implemented this before. It's actually sitting in the magic
module right now:
#[derive(Debug, Clone, PartialEq, Deserialize, Serialize)]
#[serde(rename = "___figment_selected_profile")]
pub struct SelectedProfile {
profile: Profile,
}
/// TODO: This doesn't work when it's in a map and the config doesn't contain a
/// value for the corresponding field; we never get to call `deserialize` on the
/// field's value. We can't fabricate this from no value. We either need to fake
/// the field name, somehow, or just not have this.
impl Magic for SelectedProfile {
const NAME: &'static str = "___figment_selected_profile";
const FIELDS: &'static [&'static str] = &["profile"];
fn deserialize_from<'de: 'c, 'c, V: de::Visitor<'de>>(
de: ConfiguredValueDe<'c>,
visitor: V
) -> Result<V::Value, Error>{
let mut map = crate::value::Map::new();
map.insert(Self::FIELDS[0].into(), de.config.profile().to_string().into());
visitor.visit_map(MapDe::new(&map, |v| ConfiguredValueDe::from(de.config, v)))
}
}
impl Deref for SelectedProfile {
type Target = Profile;
fn deref(&self) -> &Self::Target {
&self.profile
}
}
As the comment indicates, this works, but it has some downsides. In particular, as the comment indicates, any kind of nesting will fail:
#[derive(serde::Deserialize)]
struct Base {
profile: SelectedProfile,
}
#[derive(serde::Deserialize)]
struct Testing {
base: Base,
value: usize
}
// This panics.
let testing: Testing = Figment::from(("value", 123)).extract().unwrap();
The issue is that there's no base
field in the figment - magic only works at the top-level, since that's the only case in which serde asks to deserialize a SelectedProfile
directly instead of asking to deserialize a Base
.
As a result of this gotcha, I've opted to not included this functionality thus far.
from figment.
Completely true, I hadn't noticed that use case in which there is no profile.
from figment.
Related Issues (20)
- Pattern for mixing required fields and optional fields with defaults HOT 3
- There's no way to unset an `Option` field from env variables HOT 2
- Support FromStr/Display serialization and deserialization HOT 3
- serde(flatten) breaks metadata propagation in errors HOT 4
- Override values from configuration from CLI HOT 11
- Pattern advice: How to use config file with required field without setting it? HOT 4
- Jail create_file in subdir HOT 2
- Write back to config file. HOT 3
- [FEATURE REQUEST]: Write a jail file with non-utf8 contents
- Preserve Toml File map Order HOT 3
- Deserializing yaml structure with enumeration fails HOT 5
- Allow Value::find to traverse arrays HOT 1
- YAML Nested Values Are Not Usable Via Environment Variables with `Env::split` HOT 2
- Option _not_ to check parent directories for configuration files HOT 1
- [Feature Request] allow to override default name for environment variables HOT 5
- FigmentBuilder
- Clippy and `rustfmt` HOT 2
- Question: Conventions to overwrite nested values with env vars HOT 3
- Question: How to load vector of struct with `Env` provider? HOT 2
- Escaping Jail Error HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from figment.