Comments (2)
I was surprised that this crate isn't using Clippy (many pending lints)
We do use clippy
, we just don't fix every lint because not all of them are strict improvements. Instead of peppering the codebase with allow(clippy)
annotations, we either declare them in the [lints.clippy]
Cargo.toml file or leave them be.
and isn't formatted using
rustfmt
. This makes reading the code and contributing harder, at least for me.
As of the last time I checked, rustfmt
is still unable to format a bunch of reasonable code (like things in macro invocations) in a reasonable manner. Nevertheless, we do have code style guidelines that we rather strictly enforce. Which code are you finding hard to read?
Are you open for a PR to use both?
We have tried rustfmt
many times and each time has ended poorly. As a result we committed a rustfmt
file that simply disables rustfmt
. If the state of rustfmt
has changed significantly then I'm happy to try again, but we would want the most conservative settings that result in the smallest diff.
As for clippy: as I said we do use clippy, but if you have ways to improve our use of want to submit fixes that clippy identified, they are absolutely welcome!
from figment.
Closing as there's nothing directly actionable. Happy to field PRs as indicated above.
from figment.
Related Issues (20)
- There's no way to unset an `Option` field from env variables HOT 2
- Support FromStr/Display serialization and deserialization HOT 3
- serde(flatten) breaks metadata propagation in errors HOT 4
- Override values from configuration from CLI HOT 11
- Pattern advice: How to use config file with required field without setting it? HOT 4
- Jail create_file in subdir HOT 2
- Write back to config file. HOT 3
- [FEATURE REQUEST]: Write a jail file with non-utf8 contents
- Preserve Toml File map Order HOT 3
- Deserializing yaml structure with enumeration fails HOT 5
- Allow Value::find to traverse arrays HOT 1
- YAML Nested Values Are Not Usable Via Environment Variables with `Env::split` HOT 2
- Option _not_ to check parent directories for configuration files HOT 1
- [Feature Request] allow to override default name for environment variables HOT 5
- FigmentBuilder
- Question: Conventions to overwrite nested values with env vars HOT 3
- Question: How to load vector of struct with `Env` provider? HOT 2
- Escaping Jail Error HOT 1
- Fail to deserialize `RelativePathBuf` in a enum
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from figment.