Giter Club home page Giter Club logo

Comments (8)

mbiang avatar mbiang commented on July 19, 2024

Adding another screenshot of the permissions we request:

Screenshot 2019-03-08 14 57 54

from bonsai.

pzupan avatar pzupan commented on July 19, 2024

The permissions need to be set on the account authorizing the query to the Github endpoint.

https://developer.github.com/apps/managing-github-apps/editing-a-github-app-s-permissions/

from bonsai.

portertech avatar portertech commented on July 19, 2024

We (Sensu Inc) need to update the permission as part of the app config.

from bonsai.

portertech avatar portertech commented on July 19, 2024

The app is an Oauth app, not registered as Github app.

from bonsai.

nixwiz avatar nixwiz commented on July 19, 2024

I just saw the email announcing this to the public, however the requested permissions are still the same. Does it truly need that level of access to my repos? I am still hesitant to share anything due to this.

from bonsai.

nixwiz avatar nixwiz commented on July 19, 2024

Any updates on this? It's the one thing keeping me from sharing assets at the moment.

from bonsai.

mbiang avatar mbiang commented on July 19, 2024

@nixwiz - I've looked into this further, and apparently Bonsai is requesting the minimum level of permissions possible via Github's OAuth Scopes. Bonsai requires:

  • Ability to read repository information, specifically releases, tags, and release assets.
  • Ability to create webhooks on a repository.
  • Ability to read contributors on a repository.
  • Ability to "star" a repository
  • Ability to access basic user details, including email addresses.

Unfortunately, Github's permission system is not very granular. In order to obtain basic repository details, as well as the ability to star a repository, we have to request the "public_repo" scope to get access to release info, contributors, and the ability to star a repository. The "public_repo" scope though, contains read and write access to many other aspects of the repositories that Bonsai does not use. See Github's docs of available scopes here: https://developer.github.com/apps/building-oauth-apps/understanding-scopes-for-oauth-apps

In summary, Bonsai requests the following scopes:

  • public_repo - necessary to read contributors, releases, release assets, and to star a repository
  • user:email - allows access to user's email address(es)
  • write:repo_hook - allows write acess to repository webhooks. Bonsai adds a webhook to all registered asset repositories which notifies bonsai when a new release is created. Bonsai then automatically registers that release as a new asset version.

from bonsai.

nixwiz avatar nixwiz commented on July 19, 2024

Thanks for the response @mbiang .

from bonsai.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.