Giter Club home page Giter Club logo

eslint-config-seneca's People

Contributors

adrieankhisbe avatar ckiss avatar feugy avatar geek avatar mcdonnelldean avatar

Stargazers

avatar avatar avatar

Watchers

avatar avatar avatar avatar avatar avatar avatar avatar

Forkers

geek ckiss adrieankhisbearchives gitter-badger

eslint-config-seneca's Issues

the install command is broken 

glen@Toormore-TP300LA:/work/$ npm install --save eslint-config-seneca eslint-plugin-standard eslint-plugin-hapi 
npm WARN peerDependencies The peer dependency [email protected] included from eslint-config-seneca will no
npm WARN peerDependencies longer be automatically installed to fulfill the peerDependency 
npm WARN peerDependencies in npm 3+. Your application will need to depend on it explicitly.
npm ERR! Linux 3.16.0-52-generic
npm ERR! argv "/home/glen/.nvm/versions/node/v4.2.1/bin/node" "/home/glen/.nvm/versions/node/v4.2.1/bin/npm" "install" "--save" "eslint-config-seneca" "eslint-plugin-standard" "eslint-plugin-hapi"
npm ERR! node v4.2.1
npm ERR! npm  v2.14.7
npm ERR! code EPEERINVALID

npm ERR! peerinvalid The package [email protected] does not satisfy its siblings' peerDependencies requirements!
npm ERR! peerinvalid Peer [email protected] wants [email protected]

npm ERR! Please include the following file with any support request:
npm ERR!     /work/nearform/vidi/vidi-gc-feed/npm-debug.log

Create our own plugin

We only use a fraction of rules from both our dependencies. We could also get away with using default eslint config and deprecating some of the rules. Currently we have a lot of weight for little addition in my opinion. I'd much rather we had ownership of a single plugin and config to keep linting light.

Tasks:

  1. Create eslint-plugin-seneca
  2. Copy applicable rules from standard and hapi plugins
  3. Update the config in this repo to match the new rules and dependency
  4. Test against nodezoo.

Our depenencies should thus be,

npm install elsint-config-seneca eslint-plugin-seneca

Needs Lead Maintainer + Release Bump

Just took in some changes from @feugy I haz no NPM though :D

@naomifeehanmoran I'd say this is a nice one to add to your portfolio of lead maintainership. It really only ever needs accepting PR's releasing, not much else in it :D

Update to ESLint V2

This is a breaking change so should go on v2.x

Note Version 1.1.3 contains all the required changes, version 1.1.4 was a roll back due to the breaking nature of the change. A simple PR would resolve this issue.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.