segin / psymp3 Goto Github PK

Code doesn't check to see if anything is actually there, will attempt to load a path whether or not it's there.

Basically a null pointer dereference bug. Fix incoming.

Add support for FLAC codec

The specific command to link on Ubuntu 22.04 is:

g++ -g -O2 -lmpg123 -ltag -lvorbisfile -lSDL_gfx -lSDL_ttf -lSDL -lFLAC++ -lFLAC -lopusfile -lSDL_ttf -o psymp3 about.o audio.o display.o exceptions.o fft.o fft_draw.o flac.o font.o libmpg123.o main.o mediafile.o mutex.o player.o playlist.o opus.o rect.o scrobble.o song.o stream.o surface.o system.o track.o truetype.o vorbis.o Widget.o

Similar occurs on msys2 when building for any target (UCRT64 is my preferred)

None of the external symbols outside of C library calls seem to get resolved unless the command is invoked manually with the external libraries (.dll or .so file) explicitly passed to the linker (or compiler invoking the linker.)

Vorbis::getData() doesn't return how much of the buffer was actually filled with data; brief bursts of unexpected noise can be played at the very end of some Vorbis tracks.

Plus GCC chastises about it:

vorbis.cpp: In member function ‘virtual size_t Vorbis::getData(size_t, void*)’:
vorbis.cpp:86:1: warning: no return statement in function returning non-void [-Wreturn-type]                                                                                                                                                 
   86 | }                                                                                                                                                                                                                                       
      | ^