sebastianedwards / collection-json Goto Github PK

One of the accepted extensions of CJ is inline links. I'd love to see this feature in, since I'll be needing it a lot.

I can take care of it and send a PR.

Hi,

I'm not sure it's a collection-json bug or a rails one.

When I try to convert my collection to json it raises undefined method `merge' for []:Array.
I've managed to find that the problem is in the .to_json method of the CollectionJSON::Attribute class. More precisely with the args argument.

If I convert this:

    def to_json(*args)
      to_hash.to_json(args)                                                       
    end

To this:

    def to_json(*args)
      to_hash.to_json
    end

No more problems.
At the same time, if I'm calling JSON.generate(collection.to_hash) in my code instead of collection.to_json it's working without any problem.
collection.to_json is working great in irb.
So I suppose there is a monkey patch clash somewhere with Rails.

Thanks

EDIT:
Looking more in depth into it, the optional parameter to to_json must be hash-like. You are using a splat so here it's an array and it fails.

Converting the .to_json method to something like that fixed the problem in rails:

    def to_json(args = {})
      to_hash.to_json(args)
    end

I like to use this gem in a project, but see no official license. Is this free software? ;)

The output I get when I build a document omits the version attribute.
it would be good to have

collection = CollectionJSON.generate_for('/friends/') do |builder|
  builder.set_version "1.0"
...

to output

{ "collection" :
  {
    "version" : "1.0",
...

One extension of CJ is errors, which allows passing multiple errors in a single response. Any plans to include it?

I can take care of it and send a PR.