Giter Club home page Giter Club logo

seatsio-ruby's People

Contributors

bverbeken avatar dependabot-preview[bot] avatar dependabot[bot] avatar dsgraham avatar github-actions[bot] avatar mroloux avatar nahue avatar schaloner avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar

seatsio-ruby's Issues

client.events.create -> !! #<ArgumentError: wrong number of arguments (given 1, expected 0)>

Looks like your README is not up to date?

Creating a chart and an event

require('seatsio')
client = Seatsio::Client.new("my-secret-key") # can be found on https://app.seats.io/settings
chart = client.charts.create
event = client.events.create(chart.key) # <--- leads to following error
!! #<ArgumentError: wrong number of arguments (given 1, expected 0)>

also i tried following versions, but none of them worked:

client.events.create(chartKey: chart.id, event_key: self.event_key)
!! #<ArgumentError: unknown keyword: chartKey>
>> client.events.create(chart_key: chart.id, event_key: self.event_key)
!! #<ArgumentError: unknown keyword: chart_key>
>> client.events.create(event_key: self.event_key)
!! #<Seatsio::Exception::SeatsioException: {"status":400,"messages":["#: required key [chartKey] not found"],"errors":[{"code":"GENERAL_ERROR","message":"#: required key [chartKey] not found"}],"warnings":[],"requestId":"123"}>

Ruby 3-related deprecation error-- Proc without a block

Running Ruby 3.0 or later, the Pagination::Cursor/#each method becomes a problem.

line 33 in cursor.rb I believe is the only place the issue is present, but trying to iterate over a collection of seats objects results in a tried to create Proc object without a block error.

Query all objects of an event

Hi,

first of all, thank you very much for providing a ruby gem for your API, this will save time for us, since we don't have to handle all the http stuff by our selfes!

Right now it looks pretty fine, the only thing which we are missing right now is to get a list of all objects, with extraData included in each object. As far as I saw there is no API call for this available?

Development dependency "rest-client" seems to be required for production usage.

Hi! I've been utilising the seatsio-ruby library to interact with the Seats API. In the gemspec the gem "rest-client" is listed as a development dependency

spec.add_development_dependency "rest-client", '~> 2.0', '>= 2.0.2'
but it's required and used inside httpClient.rb
require "rest-client"
and the library won't function without it, with us having to include it in our Gemfile alongside the seatsio-ruby gem.

It would be good if rest-client was moved to be a full dependency of the seatsio gem. It does also seem that the rest-client gem is unmaintained currently and might be worth considering migrating to a different HTTP client. rest-client/rest-client#764

Handling empty chart lists

When fetching a list of charts for a subaccount that does not have any created yet, the client returns NoMethodErrors for all routine enumerable methods. A request for all charts when there are none seems to result in nil rather than an empty collection.

Alternatively, Is there an easy way to quickly see if the account does have any charts created yet?

https://docs.seats.io/docs/api-best-available ruby example shows invalid parameter names

The example in the docs for the ruby client is wrong, since it shows the first two keys (event key and size) as named parameters/hash keys, but if you look at the code, they are just normal unnamed parameters.

I think the documentation should be updated accordingly.

client.events.book_best_available key: 'event1', number: 10, categories: ['balcony', 'stalls']

def book_best_available(key, number, categories: nil, hold_token: nil, order_id: nil, keep_extra_data: nil)

Thanks!

Allow editing of handicap accessible category attribute?

When I retrieve the published version of chart, in the category list there is a boolean accessible key. However, when updating a chart's categories this key is not permitted:

Seatsio::Exception::SeatsioException (
  {"status": 400,
   "messages": [
       "#/categories/0: extraneous key [accessible] is not permitted",
       "#/categories/1: extraneous key [accessible] is not permitted"],
   "errors": [
       {"code": "GENERAL_ERROR",
        "message": "#/categories/0: extraneous key [accessible] is not permitted"},
       {"code": "GENERAL_ERROR",
        "message": "#/categories/1: extraneous key [accessible] is not permitted"}],
   "warnings": [],
   "requestId": "fee5171f-cc3f-4535-9deb-0bbbc5c06ca3"}
)

I am managing seat categories external to Seats.io and would love to be able to offer a handicap accessible option on my ticket categories.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.