searceinc / spanner-terraform-example Goto Github PK

@vignesh-sdev @rohan-searce @yogirk

I had a couple of general remarks on the current application setup, but as those files are currently not touched by any of the open PRs, it's a little bit difficult to add comments on it. I've therefore summarized it here in an issue.

Please feel free to let me know if something is not clear, or if I've misunderstood anything.

Data Model

The data model of the application uses FLOAT64 for several properties that would be better represented by other data types:

• Number of shares, both of a company as well as trade volumes, are always integers. It would be better to use INT64 instead of FLOAT64.
• Share prices are normally specified as fixed-precision numbers. It would therefore be better to use NUMERIC instead of FLOAT64 for these properties.

See

Executing queries

There are multiple queries in the application that do manual conversion of the query results to JSON. That can be done automatically by the Spanner client library by setting the json: true option in the query.

For example the function here could therefore be simplified to this:

Users.prototype.getAllUsers = async function () {
    try {
        const query = {
            sql: 'select * from company',
            json: true,
        };
        return await database.run(query);
    } catch (err) {
        throw ("error in getAllUsers function", err)
    }
}

You should also consider adding some kind of protection against out-of-memory problems in a query like this. Selecting all rows from a table without a WHERE or LIMIT clause could bring down your entire application if the table grows beyond the size that you expected.