CodeFactor found multiple issues last seen at 93dd259:

Audit url open for permitted schemes. Allowing use of file:/ or custom schemes is often unexpected.

api.py:61
api.py:81
api.py:103
api.py:112

Is your feature request related to a problem? Please describe.
When you have the Whispers of the Damned trait, you can use DA to keep the buff stacked at 6 for a longer period.

Describe the solution you'd like
If DA is talented and you have at least 1 rank of Whispers of the Damned, you should hold DA until after your first voidform to maintain stacks for as long as possible.

Without the new APL:
Whispers_of_the_Damned_1: 0.92%

With the new APL:
Whispers_of_the_Damned_1: 3.76%

Add a glossary for commonly used terms for Shadow, Priest, WoW, and SimC in general.

CodeFactor found an issue: Duplicate Code

It's currently on:
stats\profiles.py:67-76
sim.py:35-44
Commit 3760a69

When running simParser with a json file using profileSets with stat weights you get this error:

Traceback (most recent call last):
  File "simParser.py", line 103, in <module>

    main()
  File "simParser.py", line 97, in main
    parses += parse(filename, options.csv, options.hideHeaders, options.hideProfiles, options.hideActors, options.dpsOnly)
  File "simParser.py", line 37, in parse
    ret+= parseProfileSets(filename, isCsv, hideHeaders, hideProfiles, hideActors, dpsOnly)
  File "simParser.py", line 48, in parseProfileSets
    if dpsOnly or 'Int' in profile['scale_factors']:
KeyError: 'scale_factors'

Pastebin example json: https://pastebin.com/pH2XgkEd

The current things are not yet implemented/not working

Food

• Bountiful Captains Feast
• Honey-Glazed Haunchers
• Battle-Scarred Augment Rune

Potions

• Potion of Intellect
• Potion of Rising Death

CodeFactor found an issue: Starting a process with a shell, possible injection detected, security issue.

It's currently on:

• sim.py:53
  
• sim.py:59
  
• sim.py:65
  

Need the spec specific traits implemented for shadow. Assuming the general ones will be implemented by someone else?

Is your feature request related to a problem? Please describe.
Reduce duplicate code by combining reports.py into a single file across all folders

Describe the solution you'd like
A single reports.py file in the root of the repo that works with analyze.py and sim.py

Analysis.py should also export a csv of the data for easier exporting for more analysis

If thought harvester rank is greater than 0, investigate if it is worth to vampiric touch before casting mind blast if the buff is inactive

Similar to http://bit.ly/2j4XSGh from legion.

Related: #24

CC: @djriff

Created base sheet with simple weights from memory of the fights:

https://docs.google.com/spreadsheets/d/1pQBVcveJ_vN2_vj-KUFBZ1zBwsheldrmUmj5KmBSiw8/edit?usp=sharing

Is your feature request related to a problem? Please describe.
Reduce duplicate code by combining profiles.py into a single file across all folders

Describe the solution you'd like
A single profiles.py file in the root of the repo that works with analyze.py and sim.py. Ideally this is called with an argument, so you can have python profiles.py talents/

Is your feature request related to a problem? Please describe.
I would like to embed the various data tables on external websites.

Describe the bug
Analyze.py currently adds all Base actors together, these should be divided by the number of actors to get the right amount. This cannot be done until all fight profiles are done.

Expected behavior
Base actor shouldnt have an int weight higher than 1.

Is your feature request related to a problem? Please describe.
Need to determine if it is worth it to dump MB/SWV charges before using DA

Describe the solution you'd like
If you are out of voidform, before popping DA the actor should use all available Mind Blast or SW:V charges.

Additional context
If you pop DA at 0 insanity it'll shorten that Voidform

Steps to add dungeons:

Profiles.py

1. Add in a --dungeons flag
2. Edit the if statement for sanitizing input
3. Add in profiles to map to (probably import a new file)
4. Add some block similar to how i checked for composite
5. Add a new reports list
6. Set report based on input
7. Set simc file name per file in the loop
8. Append sim settings based on input per profile

Weights.py

• Add weights for BFA dungeons to use

Sim.py

1. Add in a --dungeons flag
2. Set reports
3. Determine sim files
4. Determine lookup value to cross check sim name with weights.py to skip if weight is 0
   • Also need to edit this
5. Add in additional argument to analyze.py

Analyze.py

1. Add dungeons flag
2. If dungeons flag set edit output files to Results_Dungeons.X
3. TBD on this piece, lots of different ways to do this, most of the existing code might already work
   • Base would need to be updated (i.e. divide by the number of base actors depending on how things are split)
   • Would need to edit the output headers

Dark ascension is bugged and is currently doing 20% too much damage.

https://cdn.discordapp.com/attachments/234014456584077313/459455077330190336/image.png

Kaesebrezen - Today at 3:31 PM
the damage thing is because the shadowpriest aura hasn't dark ascension listed on it
because ingame it's treated fully as a void eruption cast

da_mul 1.088 vs da_mul 1.36

1st commit: simulationcraft/simc@c0ece41

Is your feature request related to a problem? Please describe.
Current google sheet charts are great as they pull from the repo, however the look cannot be customized as much.

Describe the solution you'd like
I've already built a script that will convert sim data to JSON data that should be easily read by a JS script for highcharts

Additional context
Rough Functions Required:

• Load JSON data,
• Plug it into highcharts
• Setup colors for each ilvl
• tell the chart which data is which (organized in the JSON neatly)

Is your feature request related to a problem? Please describe.
It's frustrating having to scroll down a ton to see the single target chart. Having them stacked side by side would be easier to view.

Describe the solution you'd like
A way to see both charts side by side for easier analysis.

Need to add a new section to sim that compares all available trinkets at various ilvls.

https://bfa.wowhead.com/trinkets/class:5/role:2?filter=166;8;0#50-2

Need to create a spreadsheet to analyze consumable data

After the raid releases iterate over the existing weights that were created in the original issue:
#40

Is your feature request related to a problem? Please describe.
Analyze.py and Analyze.rs should be combined into a single file

Shot tested in-game vs. SimC timings of void bolt and noticed a pretty large difference.

The times in the chart are the seconds between each void bolt. Either there is a problem with mind flay not respecting the interrupt=1 in the APL, or Void Bolt isn't scaling properly with haste.

The problem doesn't really exist at all in the legion version of SimC, there's a chance our haste levels in legion just masked this problem, or something else changed between legion and bfa dev of SimC to break this.

Full spreadsheet of data here

It's semi difficult to look through the charts and find out which trait is best in comparison to others

Solution: Potentially Seperate out by tier and use only 1 trait of each rather than a stack of 2 or 3.

If a sim has a weight of 0, it should not sim it. After this change need to confirm analysis.py still works as expected.

Need charts for this page: https://warcraftpriests.com/?p=1547&preview=true

• each heading needs its own charts published at the correct width (if the chart is published too wide it will not show up in the post properly
• Need to fix chart titles (or remove all together) to match the heading

Mythic raid gear drops at 385, need to determine titanforge cap and add the extra ilvls of all trinkets to that point for the launch of BfA.

• Check order
• Add talent check to skills if=talent.dark_void.enabled

Dependent on #1

• For azerite traits/gear compare, anytime the AS trait is taken add a second entry that alters the talent choice to add a base Actor with AS, and a new actor with AS + trait
• For talent comparisons, add 1, 2, 3 ranks of the AS rank side by side with other talent choices

Need to create a spreadsheet to analyze racial bonuses data

Also have these: https://github.com/Juliacare/RaidSimming

Need charts for this page: https://warcraftpriests.com/?p=1554&preview=true

• each heading needs its own charts published at the correct width (if the chart is published too wide it will not show up in the post properly

https://github.com/simulationcraft/simc/wiki/Examples#compute-stats-scaling

When trying to use shadow crash in precombat you get this message:

Player DA_Mindbender_Wait attempted to add harmful action shadow_crash to precombat action list. Only spells with travel time/cast time may be cast here apparently SC doesn't have a travel time in SimC

sample action list against 2 targets, seems the min: logic is broken?

Some trinkets in simc do not behave as they do in game currently. The sheet I made helps address this.

Compare values from in game data (logs) and make sure simc and the sheet both match these values

Some trinkets are hilariously overpowered at the moment and skew results. For example, there's a trinket that erroneously has 100% uptime, which greatly inflates it.

Need to add this trinket to simc + trinket sims:

http://www.wowhead.com/item=163937

Before adding need a table that maps shadow spells to buff.

With the amount of damage Void Eruption does, on X targets or X duration is it ever better to just wait in voidform to be able to Void Eruption again?

Describe the bug
Occasionally raidbots will error out, or the script will error. If an error occurs when submitting, polling, or pulling the result of a sim the script should auto retry.

To Reproduce
Run a sim and wait for raidbots to error

Expected behavior
I expected the script to detect the error neatly, and retry the sim without flooding the terminal output.

Spreadsheets
N/A

Additional context
N/A

Seems like there are some sets/gear that should get simmed

• Seabreeze Weapon

• Nightborne: verify Arcane Pulse is used on cooldown
• Blood Elf: Arcane Torrent
• Troll: Berserking
• Lightforged Draenei: verify Light's Judgment is used on cooldown
• Goblin: verify Rocket Barrage is used on cooldown

i.e.

  // Racials
  if ( race == RACE_BLOOD_ELF )
    default_list->add_action( "arcane_torrent,if=buff.voidform.down" );

Need to build out sims/analyze data for best gear combinations for the T22 profiles.

Need to create a spreadsheet to analyze enchant data

For some reason, ansh wants stat weights for every talent combo. Cuz he's ansh.