seanoshea / blueplaqueslondon Goto Github PK

Should be updated for 2015

One or two areas in the codebase which need to be updated.

Set up the project again as an iOS 8/Xcode6 project.

brew upgrade xctool failed.

See https://travis-ci.org/seanoshea/BluePlaquesLondon/builds/118823783

Code coverage should be displayed inline whenever unit tests are run.

1.9 Version

Sir Malcolm Sargent is one example of where this can go wrong.

All unused Images should be removed from the application.

Title says it all

It's possible to remove source code of Reachability from the project and use pod instead (https://github.com/tonymillion/Reachability). However some issues related to rejecting apps were found (tonymillion/Reachability#96). That's why I want to discuss if it needed or not.

New Plaques from Roy

Snapshot for screenshots of the app

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/IntentKit/IntentKit/Core/Helpers/NSString+Helpers.m:39: warning: PARAMETER_NOT_NULL_CHECKED
Parameter ink_urlEncode is not checked for null, there could be a null pointer dereference: pointer ink_urlEncode last accessed on line 39 could be null and is dereferenced at line 39, column 95

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/IntentKit/IntentKit/Core/Helpers/NSString+Helpers.m:58: warning: PARAMETER_NOT_NULL_CHECKED
Parameter ink_urlEncode is not checked for null, there could be a null pointer dereference: pointer ink_urlEncode last accessed on line 58 could be null and is dereferenced at line 58, column 92

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMBlockCaller.m:25: error: NULL_DEREFERENCE
pointer self last assigned on line 24 could be null and is dereferenced at line 25, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMConstraint.m:149: warning: IVAR_NOT_NULL_CHECKED
Instance variable self -> block is not checked for null, there could be a null pointer dereference: pointer self->block last accessed on line 149 could be null and is dereferenced at line 149, column 9

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMIndirectReturnValueProvider.m:26: error: NULL_DEREFERENCE
pointer self last assigned on line 25 could be null and is dereferenced at line 26, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMLocation.m:29: error: NULL_DEREFERENCE
pointer self last assigned on line 28 could be null and is dereferenced at line 29, column 5

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMMacroState.m:83: error: NULL_DEREFERENCE
pointer self last assigned on line 82 could be null and is dereferenced at line 83, column 5

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMNotificationPoster.m:25: error: NULL_DEREFERENCE
pointer self last assigned on line 24 could be null and is dereferenced at line 25, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMPassByRefSetter.m:25: error: NULL_DEREFERENCE
pointer self last assigned on line 24 could be null and is dereferenced at line 25, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMReturnValueProvider.m:27: error: NULL_DEREFERENCE
pointer self last assigned on line 26 could be null and is dereferenced at line 27, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCMVerifier.m:29: error: NULL_DEREFERENCE
pointer self last assigned on line 28 could be null and is dereferenced at line 29, column 5

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/OCMock/Source/OCMock/OCObserverMockObject.m:30: error: NULL_DEREFERENCE
pointer self last assigned on line 29 could be null and is dereferenced at line 30, column 2

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/TBXML/TBXML-Code/TBXML.m:902: error: NULL_DEREFERENCE
pointer self->currentElementBuffer last assigned on line 901 could be null and is dereferenced at line 902, column 3

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/TBXML/TBXML-Code/TBXML.m:907: error: NULL_DEREFERENCE
pointer self->currentElementBuffer->next last assigned on line 906 could be null and is dereferenced at line 907, column 3

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/TBXML/TBXML-Code/TBXML.m:921: error: NULL_DEREFERENCE
pointer self->currentAttributeBuffer last assigned on line 920 could be null and is dereferenced at line 921, column 3

/Users/s.o_shea/dev/github/BluePlaquesLondon/Pods/TBXML/TBXML-Code/TBXML.m:925: error: NULL_DEREFERENCE
pointer self->currentAttributeBuffer->next last assigned on line 924 could be null and is dereferenced at line 925, column 3

For travis is a little disconnected. Might be a good idea to consolidate into the travis.yml file?

Upgrade iRate

In preparation for moving to size classes, should make iOS9 a pre-requisite.

Could do with a bit of a cleanup. There are some old references to importing UIKit.h and Foundation.h which could be cleaned up.

Should include some swift unit tests for the extension just to make sure it works as expected.

Sometimes the unit tests fail because BPLURLResourceLoader doesn't seem to be triggering. Need to resolve this with some regular HTTP stubbing.

Add new Blue Plaques into the app

There are some instances where the data is a little funky in that there should be multiple placemarks at a point, but they all relate to the same person. See Joseph Banks as an example.

It would be useful for the development to have a vision of required features and improvements which are necessary for next or current release. So other developers can fully understand what they can do and how to help. From my point of view some kind of Roadmap or TODO list will be enough for that purpose.

3X assets

Should be just 'Plaques'

Instead of using Crashlytics directly, perhaps just use Fabric.

Some corrections.

Should have coveralls and travis-ci metrics as part of the README file.

Shouldn't be necessary for two separate storyboards given that the interface is insanely similar on either device. Would be good to clean up this duplication.

Roy sent on some new plaques. Should update the app to include them.

Re-enable Crash Reporting

Should get them in the app and make sure the unit tests still pass.

Copyright Notice

I think we could use appIcon image to fill empty space and to emphasize project style. Something like this:

Its out of date.

Should be integrated into the project.

Should be using copy for copy properties in initializers. Should also convert to Modern Objective-C syntax where possible.

Should have at least some integration testing for the application. Either Frank/Calabash.

Should really consider upgrading per the pod warning message.

Should be brought into the next version of the app

There should be an Today Extension for the Blue Plaques London application.

This extension should allow the user to quickly find their closest Blue Plaque.

Revisit fastlane implementation

For iPhone 6sssss

Should be on the latest.

The change over to UIAlertController is definitely a positive one, but I think the unit tests should have failed with this change, but it looks like current set of assertions being made in the unit tests weren't stringent enough to ensure that the tests failed.

Should add some new unit tests to the test suite to ensure that something like this doesn't happen again.

iPad Pro Image

Upgrade Google Maps

New Plaques from Roy

New Plaques from Roy

Sometimes crashes if the app has to fully load the KML file when the user requests that the app opens.

I suggest to set specific version for each pod, rather than update to the latest (if no version specified)