sdwilsh / tree-bot Goto Github PK

JavaScript 100.00%

tree-bot's Introduction

afrosdwilsh's IRC manifestation.

Things it may understand if addressed in the channel:
watch <tree>
unwatch <tree>
watch <changset> on <tree> (for <person>)
unwatch <changset> on <tree> (for <person>)
<email> is <name>
I am <email>

tree-bot's People

Contributors

Stargazers

Watchers

Forkers

zpao leibovic gavinsharp

tree-bot's Issues

Bot should respond to 'help' with list of commands

currently: a command to list everything it's watching

would be nice to be able to get the current state of the bot

respond accordingly when told to unwatch something it isn't watching

right now if you say unwatch random-tree-that-was-never-watched it'll just say that it stopped watching, even when it never started.

Add local configuration

Would be handy for remembering which channels to join, trees to watch, etc...

add package.json

Makes it easy to get up and running, just npm install from the project root. I don't think this is a package that'll get published on npm so we don't need the full package spec.

/usr/home/dev/tree-bot/builds.js:64
builddata.rev = property[1].substr(0, 12);
^
TypeError: Cannot call method 'substr' of null
at /usr/home/dev/tree-bot/builds.js:64:37
at Array.forEach (native)
at createBuildData (/usr/home/dev/tree-bot/builds.js:52:24)
at EventEmitter.messageConsumer (/usr/home/dev/tree-bot/builds.js:184:14)
at EventEmitter. (native)
at EventEmitter.emit (events.js:64:17)
at EventEmitter. (/usr/home/dev/node_modules/pulse/pulse.js:50:14)
at native
at Message. (/usr/home/dev/node_modules/pulse/node_modules/amqp/amqp.js:1362:27)
at Message.emit (events.js:61:17)

Add natural typing delay to bot responses

Need to ignore hidden tests

Right now we report errors for jetpack which is hidden on tinderbox.

Crash in builds.js

TypeError: Cannot call method 'indexOf' of undefined
at /usr/home/dev/tree-bot/builds.js:161:55
at IncomingMessage. (/usr/home/dev/tree-bot/builds.js:91:9)
at IncomingMessage.emit (events.js:81:20)
at HTTPParser.onMessageComplete (http.js:133:23)
at Socket.ondata (http.js:1213:22)
at Socket._onReadable (net.js:681:27)
at IOWatcher.onReadable as callback

Provide logfile url for events

Less hacky for the UI doing it.

Event revision is inconsistent

Got this right in a row:
on tree mozilla-central got event success for revision 941ceabc5417 with result 0 and cached status undefined
on tree try got event success for revision 941ceabc5417 with result 0 and cached status undefined

Seems unlikely? The revision does exist on both m-c and try though.

event.rev is sometimes None

on tree mozilla-central got event success for revision None with result 0 and cached status undefined

Don't have STR.

Listen to errors from Pulse

I need to fix this upstream first, but we should be able to do on("error", ...); to get status information on errors.

Crash on forced disconnect

Unhandled connection error: CONNECTION_FORCED - broker forced connection closure with reason 'shutdown'

node.js:134
throw e; // process.nextTick error, or 'error' event on first tick
^
Error: CONNECTION_FORCED - broker forced connection closure with reason 'shutdown'
at Connection._onMethod (/usr/home/dev/tree-bot/node_modules/pulse/node_modules/amqp/amqp.js:959:15)
at AMQPParser.onMethod (/usr/home/dev/tree-bot/node_modules/pulse/node_modules/amqp/amqp.js:807:12)
at AMQPParser._parseMethodFrame (/usr/home/dev/tree-bot/node_modules/pulse/node_modules/amqp/amqp.js:454:10)
at AMQPParser.execute (/usr/home/dev/tree-bot/node_modules/pulse/node_modules/amqp/amqp.js:205:20)
at Connection. (/usr/home/dev/tree-bot/node_modules/pulse/node_modules/amqp/amqp.js:847:12)
at Connection.emit (events.js:64:17)
at Connection._onReadable (net.js:676:14)
at IOWatcher.onReadable as callback

Support abbreviations for tree names / validate tree names

m-c -> mozilla-central

We need to canonicalize the name in the UI code though so this should be exposed as some function which maps strings to string or undefined.