scroll-tech / frontends Goto Github PK

Describe the bug
A clear and concise description of what the bug is.
连接scroll.io bridge 无法识别 eth 余额

To Reproduce
Steps to reproduce the behavior:

Expected behavior

如上图，应该能够识别出来有 0.01ETH 但是 显示0 balance

Screenshots

Desktop (please complete the following information):

• OS:
• mac OS 13.4
• Browser
• Chrome 已是最新版本
  版本 119.0.6045.159（正式版本） (arm64)
• Version

Smartphone (please complete the following information):

• Device:
• OS:
• Browser
• Version

Additional context

Description:
Part of a text is overlapping a SVG on any screen smaller than 600px.

The bug is where it says: "Mainnet Housewarming Party", almost at the end of the website, in the index page.

Note how on the screen in which the width is 600px, nothing happens, but on the the other screen of 599px, it's overlapping.

The bug can be fixed if the height is changed to 15rem or higher.

add discord, medium etc near X logo

When semi-scrolled down and clicking on a filter button scroll the page to the top while filtering

I've been working with the react-cool-img package in the project and noticed that a default placeholder image isn't specified for the Img component in case the hash prop is missing. This can lead to instances where no image is displayed, impacting the user experience.

Proposed Change:
I suggest adding a condition to the placeholder prop to ensure a default image is used if hash is not provided. This is the change I implemented:

<Img
  alt={name}
  src={`${ecosystemListLogoUrl}${name}${ext}`}
  placeholder={hash ?? "/logo.svg"}
  width={isMobile ? 48 : 88}
  height={isMobile ? 48 : 88}
></Img>

Benefits:
This change will ensure that a visual element is always present, improving the user experience by providing a consistent and graceful fallback.

I would love to hear your thoughts on this and discuss further improvements.

The version of node used for compilation?

Hello everyone, there are a few small fixes I would like to propose. First of all on the main page the navbar, when I press the Develop button at the top of the page the dropdown has no background so it is below the first text titles.

Another is that if I open the All Networks button to select whether testnet or mainnet, it happens that when I scroll down or up it locks completely.

I would also recommend to put a more subtle button for the social network X, or the one you have directly, because the "X" logo next to the name gets lost.

Describe the bug
EmptyNetwork is defined using ValidNetwork<string, never>, which suggests that ValidNetwork was intended to be a generic type. However, ValidNetwork is defined as a concrete type with specific properties and does not accept generic parameters. This is why TypeScript interprets EmptyNetwork as any.

To Reproduce
Steps to reproduce the behavior:

1. Go to: src/types/network.d.ts
2. Check type of EmptyNetwork

Expected behavior
If the goal is to create a type EmptyNetwork that represents a "network" with potentially missing or empty fields based on ValidNetwork, generics should not be used in this case.
Instead, you can use utility types like Partial for making all properties optional or use other TypeScript features to modify the existing ValidNetwork type.

Screenshots

Additional context
In the current implementation the type of Network is quite useless, because it implies being "any" because of this incosistency with EmptyNetwork.
Possible solution would look something like this:

type EmptyNetwork = Partial<ValidNetwork>;

Describe the bug
On the bridge page, when you click on the 'Transactions History' button and the dialog opens, the loading state overlaps with the No data state. It needs segregation.

To Reproduce
Steps to reproduce the behavior:
1- Go to the Bridge page on the Scroll app
2- Click on 'Transactions History' button
3- The dialog opens
4- If there are no transactions, the loading icon overlaps with the No-data state

Expected behavior

Screenshots

Desktop (please complete the following information):

• OS:
• Browser
• Version

Smartphone (please complete the following information):

• Device:
• OS:
• Browser
• Version

Additional context
I have created a pull request for the above mentioned fix.

Describe the bug
The error message on the newsletter subscription, where you input email, should show red and not the normal text colors as this is the standard for error message to improve users experience.

To Reproduce
Steps to reproduce the behavior:

Expected behavior
the error message should be in red text or have a red warning sign to indicate and show users they are doing something wrong.
i am a frontend developer and can easily solve this isssue.

Screenshots

I think the size of the transaction pop-up notification is too big; perhaps it can be made simpler with a smaller size.

pages: bridge

After entering the NFT tab under the ecosystem, when we press the load more button, the first data comes, but if I press the load more button for the second time, the page gives an error.

You can find the video link below

Looking at the ecosystem directory (which is very helpful), it might be good to add a 'rate dapp' feature for users to share brief experiences with a given dapp.

We're all aware that some are better than others, albeit often at different points in time.

I think this would be a good community feature.