Typescript compilation error: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier. about scramjet HOT 12 CLOSED

Hey, thanks for the comment, we're on it. :)

from scramjet.

@AndrewGrachov can you extract a simple repo for instance with a single file that causes the above issue? We'd check if we can reproduce this.

Or at least share the code that uses scramjet?

from scramjet.

https://github.com/AndrewGrachov/scramjet-error

here you are, I suspect yarn

from scramjet.

dockerfile build should fail

from scramjet.

Thanks, I'll check - I believe I'll need to redo the pipeline method override in all streams - I don't know why it's like that in ts since pipeline is not a method of Readable or Writable or any other Node.js stream, but worst case scenario I'll just allow any there...

from scramjet.

I'm trying to fix this - but this is taking some extra time, as I don't really know how to make Typescript ok with overriding of some of Duplex/PassThrough stream methods (pipeline mostly).

I'll try to solve it in such a way that this will be compatible - I'll create a PR over the weekend and perhaps you could help me with getting the definitions right.

from scramjet.

Still working on this - it's a bit annoying since I added the pipeline method before it was added to Transform stream and then the method was made incompatible which doesn't go well with Typescript.

from scramjet.

Another update - we're focusing on Scramjet v5.x branch now, as we're trying to pass a tipping point there - still we'll return to this asap.

from scramjet.

Ok, fix underway - I needed to remove the pipe method altogether and use node's own one. There's a possible compatibility issue, but if that occurs for anyone - it's most likely to be a bug (so you'd need to fix that in your own code).

@AndrewGrachov tell me if it's now working for you with 4.34.0 - I'll publish this in a couple minutes.

from scramjet.

@AndrewGrachov shall we close this?

from scramjet.

Build is ok, thank you!

from scramjet.

Brilliant. 👍

from scramjet.