Getting error Class 'PromiseTransform' incorrectly implements class 'Readable' and 'Writable' about scramjet HOT 12 CLOSED

Ok. But that's a good lead - it is how I thought.

I'll follow up this week. If you can try to somehow mute this error in typescript config then please try to do so as a workaround. We'll fix this, but I can't give you dependable timelines yet (worst case scenario is end of the month).

M.

from scramjet.

My bad, the package was published to the internal repo. Thanks for the heads up.

I'll release today

from scramjet.

Fantastic! Another win for fixing at night, and another near-miss for deploying then. :D

from scramjet.

@MichalCz , @luccam-scr , @stokowski , @S4adam , can you please look into this issue?

from scramjet.

Will check. Typescript definitions of node/stream used to be pretty bad, so if you could try to downgrade @types/node to something older (16) and rebuild then I'd know where we stand.

A small issue I'm having is the very outdated way the definitions are done - so there are two options: if method signatures need changing it will be problematic, if only missing props are added, this should be easy.

I'm also seeing a small issue with the tests, but that's a false positive.

Anyway @shahabali1993, please confirm if downgrading @types/node to 16.x allows you to build Scramjet. If we're lucky that won't make your own build fail - if that's the case let me know, I'll try to set up a small test repo.

from scramjet.

@MichalCz thank you for the quick response, downgrading @types/node to 16.x worked with scramjet but now getting another issue with 'AbortSignal' related @types/node in file globals.d.ts.

Here's the link if you would like to follow:
DefinitelyTyped/DefinitelyTyped#66617

Scramjet and @types/node will have to be upgraded to latest in the future though.

from scramjet.

Thanks @MichalCz , please do inform here when it is fixed.

from scramjet.

Hey @shahabali1993 - I have the solution, but I still need to make this work with the build script. I'll inform you on the progress.

from scramjet.

@shahabali1993 please check with 4.37.0.

from scramjet.

@MichalCz I am unable to find 4.37.0, can you please specify where I can find it?
I tried updating the version in my package.json but it didn't work.

from scramjet.

It's published now. :)

from scramjet.

@MichalCz thank you for the quick fix.

Verified 4.37.0.
All errors have been resolved, scram-jet 4.37.0 is now working with the latest version of types/node 20.6.0.

from scramjet.