View Code? Open in Web Editor
NEW
This project forked from stickeeuk/magpie-developer-challenge
Magpie developer challenge
PHP 43.53%
Shell 0.17%
Dockerfile 0.50%
HTML 55.80%
magpie-developer-challenge's Introduction
- Bring up container
docker-compose up -d
- Copy
.env.example
to .env
: cp .env.example .env
- Run scraper
docker-compose exec app bin/console scrape:phones:json storage/output.json
- Run tests:
docker-compose exec app vendor/bin/phpunit
- More test coverage across services / transformer / command.
- Feature tests actually hitting the endpoint.
- Clean-up how
$colour
gets passed into transformer - anti open-closed principle
- Make some of the logic for parsing data (e.g. shipping date delimiters) configuration based.
- Get a pipeline / grunt working for auto lint / testing.
- Not sure if we should be treating available from / shipping from the same as shipment dates. Assumed yes.
magpie-developer-challenge's People