schultzcole / fvtt-gm-secret-block Goto Github PK

the words GM Secret tends to be really difficult to see when using dark mode.

It might be possible to resolve this simply by applying contenteditable="false" to GM secret blocks when the user is not the GM.

This setting would lock it down so that non-gm users can't use any of the existing editor exploits to bypass GM secret blocks by preventing them from opening the editor for descriptions that contain a gm secret block.

To a user that knows what's happening, this would be an instant tip-off that a GM secret exists, however it may be worth it for some GMs who want a bit more assurance that their players can't view secret content.

This might be possible to fix relatively easily by disabling selection of gm secret sections, but that's not guaranteed to work.

Behaviour:
When Polyglot is installed, it seems to override the Paragraph menu options and prevent GM Secret Block from adding the GM Secret option to the Custom menu. This does not break GM Secret blocks themselves, and it only seems to affect areas where Polyglot adds its own list of languages to the text editor options.

• Actor and Items text editing is unaffected (Polyglot doesn't apply to these anyways).
• Journals are affected - however, if you disable Polyglot and then add a GM Secret to a Journal, and the re-enable Polyglot, you are no longer able to add new GM Secrets to Journals (the menu option disappears), but the previously added GM Secret block remains untouched.

Steps to reproduce:

1. Enable GM Secret Block
2. (optional) Create a journal entry and write a GM Secret block of text
3. Enable Polyglot
4. Click to edit journal entry from step 2, or create a new journal entry
5. (optional with step 2) Observe that the GM Secret block you wrote remains intact
6. Observe that the GM Secret option is no longer present in the Paragraph dropdown menu, while Polyglots language list is present
7. (Optional) observe that Actor and Item sheets are not impacted due to the lack of Polyglot support in these windows

Expected behaviour:

• Polyglot and GM Secret block should not interfere with one another

Test environment
Foundry 0.7.9 + DnD5e 1.2.3
GM Secret Block v1.0.0
Polyglot 1.4.0

• Reproduced with no other modules active

Is there anyway to get the secret text to output to chat as well? Right now only the non-secret text shows up in chat, but it would be a nice quality of life upgrade for people with the appropriate view permissions to see the secret text in the chat.